Hi,

Thanks for the module, it does exactly what I was looking for.
I'm experiencing an issue with the "Insert row at the bottom" option, this is not really a bug but...:
if the option "Insert after every Nth row" is set to a number that is a divisor of the total rows count and the option "Insert row at the bottom" is checked then it is like if two row were inserted at the end.

For example if my views return 12 rows and I set "Insert after every Nth row" to 4 (2, 3, 4 or 6 is the same) and I check the option "Insert row at the bottom" then VRI insert one row after the 12th row and another for the option "Insert row at the bottom".

I don't really know how to provide a patch (and if it is needed!) but in file views_row_insert.theme.inc changing line 93 from this

if ($row_footer)

to this

if ($row_footer && $k > 0)

will avoid to display the last row twice.

I'm clear enough? Is it correct?

Thanks

Edit: added patch (at least I think...)

CommentFileSizeAuthor
#2 avoid-insert-last-row-twice-3015531.patch467 bytesdrupix

Comments

drupix created an issue. See original summary.

drupix’s picture

Issue summary: View changes
StatusFileSize
new467 bytes
brightbold’s picture

Status: Active » Needs review

Setting to "needs review" since you provided a patch.