Problem/Motivation

Currently, phpstan and phpcs pipelines are failing.

Proposed resolution

Fix it.

Issue fork views_random_seed-3585492

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vitaliyb98 created an issue. See original summary.

vitaliyb98 opened merge request !5

vitaliyb98’s picture

vitaliyb98 commented
Status: Active » Needs review

Fixed existing pipelines, except for this issue:

Class Drupal\search_api\Plugin\views\query\SearchApiQuery not found.

The module uses a class from the Search API module, but it does not declare it as a dependency in either composer.json or the .info.yml file, I suggest adding it as a dependency.. As I understand it, it is an optional dependency.

swentel’s picture

swentel commented

I guess it could go as a 'suggest' in composer maybe?

vitaliyb98’s picture

vitaliyb98 commented

Added, but it doesn't help.

swentel’s picture

swentel commented

True, you'll have to add an inline comment so phpstan ignores that line .. I can't find a direct example but I know that should work normally.

vitaliyb98’s picture

vitaliyb98 commented

Thanks, I will try it

BTW, is this module open to co-maintenance if I invest my time in reviewing existing issues and contributing further improvements?

swentel’s picture

swentel commented

Sure, I'm less active in Drupal in general, so would be great to have someone helping out, and even tag new releases.

vitaliyb98’s picture

vitaliyb98 commented

Added // @phpstan-ignore class.notFound

Synced current branch with latest changes from the 8.x-1.x (rebased)

swentel’s picture

swentel commented
Status: Needs review » Fixed

Thanks, merged!

You have maintainer access now, feel free to tag releases! :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

vitaliyb98’s picture

vitaliyb98 commented

Thanks!