Problem/Motivation

As per https://www.drupal.org/node/3070687 testing modules should not have either core or core_version_requirement keys set. These now cause exceptions to be thrown.

Proposed resolution

Remove the key "core" from "views_test_linkarea.info.yml"

Issue fork views_linkarea-3268564

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !4

marciaibanez’s picture

marciaibanez
she/her
Primary language Portuguese, Brazil
Location São Paulo
commented
Assigned: Unassigned » marciaibanez

I'll work on this.

marciaibanez’s picture

marciaibanez
she/her
Primary language Portuguese, Brazil
Location São Paulo
commented
Assigned: marciaibanez » Unassigned
Status: Active » Needs review

Hi! I removed the core key and also changed the core_version_requirement from ^8 || ^9 to ^9 || ^10. The issue says to remove the core key in this file: views_test_linkarea.info.yml, but the core key was already removed in it, so the changes I made are in this file: views_linkarea.info.yml. If I did anything wrong or can do something else to help, please let me know, kindly review it :)

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

Anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs review

I don't think it's ok to not have any of 'core' or 'core_version_requirement' in any module info.yml!
Added it accordingly.

Has the compatibility against Drupal 10 been ensured?

grevil’s picture

grevil commented

@marciaibanez The changes were only needed in the test file, which I already implemented! Sry, should have pointed that out in the thread here. As @Anybody said, the "core_version_requirement" is required in "views_linkarea.info.yml". And I am not sure about Drupal 10 compatibility, but if you tested it, it's probably correct!

grevil’s picture

grevil commented
Issue summary: View changes
grevil’s picture

grevil commented
Issue summary: View changes
grevil’s picture

grevil commented

Also, if we want to have Drupal<8.7.7 support, the module also requires the "core" key. See here

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Re #11 as Drupal 8 is EOL that's OK. 8.7.7 is old.
But the maintainer has to decide. ;)

I'm maintainer and I'm ok with that.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

RTBC as of #5.

  • Anybody committed 004f1da on 8.x-1.x authored by Grevil 
    Issue #3268564 by Grevil, Anybody, marciaibanez, thomas.frobieter:...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Finally decided to use
^8.9 || ^9

as ^10 should be tested first! I don't want to set that blind.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Fixed in 8.x-1,3!

Edit: Just saw I can't create releases here. Contacted https://www.drupal.org/u/jludwig

jludwig’s picture

jludwig commented
Status: Fixed » Closed (fixed)

Released as 8.x-1.3. Thanks to everyone involved and to @Anybody for contacting me about making the release.