PHP 7.2 compatibility: create_function() is deprecated [#3003518]

Hello,

PHPCS compatibility reports the following warnings for PHP 7.2:

FILE: .../views_json_query/views_json_query_plugin_query_json.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
 256 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 257 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 258 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 259 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 260 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 261 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
 262 | WARNING | Function create_function() is deprecated since PHP 7.2;
     |         | Use an anonymous function instead
     |         | (PHPCompatibility.PHP.DeprecatedFunctions.create_functionDeprecated)
----------------------------------------------------------------------

Patch will follow.

Comment	File	Size	Author
#7	views_json_query_php_7_compat-3003518-7.patch	1.7 KB	emersonreis.dev
#3	views_json_query_php_7_compat-3003518-3.patch	1.85 KB	herved

Comments

Comment #1

1 October 2018 at 12:54

herved created an issue. See original summary.

Comment #2

herved commented 1 October 2018 at 12:57

Issue summary:

View changes

Comment #3

herved commented 1 October 2018 at 13:01

Status	File	Size
new	views_json_query_php_7_compat-3003518-3.patch	1.85 KB

Here it is.
This simply uses a switch/case.
I also used drupal_strlen() instead of strlen() as recommended by phpcs.

Comment #4

herved commented 1 October 2018 at 13:01

Status:

Active

» Needs review

Comment #5

rajesh kairamkonda commented 24 June 2019 at 14:31

@herved
Your patch is not working.

patching file views_json_query_plugin_query_json.inc
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 252.
2 out of 2 hunks FAILED -- saving rejects to file views_json_query_plugin_query_json.inc.rej