Like Google Analytics, the module name differs from the directory name here.

The directory is views_if_empty but the module name is views_ifempty.

I'm partial to views_if_empty myself, but changing the module name would require some effort on the part of anyone using the module. But, since it's still in a sandbox, this should not be a significant issue, and it would be best to fix it before promoting to a full project anyway.

What do you think, Ben? I can write a patch to change file and hook names if you agree that's the way to go.

Comments

benclark’s picture

benclark commented
Component: Code » Miscellaneous

So, this is a quirk of the sandbox project: there's no way to separate the project title from the short title used in the git instructions. If this was a full project, I would have specified views_ifempty to be the short title and it would then match my *.{info,module} files.

I'm partial to keeping it views_ifempty, if only because changing it would mess with everyone who may have downloaded & installed it already. However, I can change the title of the project to Views Ifempty so the git instructions create the correct directory name.

Does that sound like the right solution, Brock? I appreciate you weighing in on this -- a mismatched directory/module name is a bit of a pet peeve of mine, too.

BrockBoland’s picture

BrockBoland commented
Status: Active » Closed (works as designed)

Aaaah, I forgot that it generates the name for sandbox projects. If I'm not mistaken, you can choose the shortname when promoting it to a full project, so you can make it views_ifempty then.

Speaking of which, I'll just leave this here: http://drupal.org/node/1011698