While evaluating this module, I noticed it lacked a readme.
According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Patch to follow, thanks!

CommentFileSizeAuthor
#4 interdiff-3014798-2-4.txt386 bytesvolkswagenchick
#4 views_fieldsets-readme-3014798-4.patch2.32 KBvolkswagenchick
#2 views_fieldsets-readme-3014798-2.patch2.32 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new views_fieldsets-readme-3014798-2.patch2.32 KB

I uploaded a patch that adds a useful readme as per Drupal documentation standards.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Needs work

Looks good but has

+++ b/README.md
@@ -0,0 +1,78 @@
+ ¶

An extra space (line 63)
Thanks

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review
StatusFileSize
new views_fieldsets-readme-3014798-4.patch2.32 KB
new interdiff-3014798-2-4.txt386 bytes

I uploaded a new patch and an interdiff for easy review.

Thanks for the review.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Reviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good. Patch applied.
Marking as RTBCed.
Thank you for working on module!

alex_optim’s picture

alex_optim
Location Tallinn
commented

Good for me.

pifagor’s picture

pifagor commented

pifagor’s picture

pifagor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.