The committed patch from #2173259-5: Confirmation message not visible tests

if (isset($variables['rows']['#vbo_confirm_form_title'])) {

assuming that if $variables['rows'] is defined, it is an array. Unfortunately when a string is provided, $variables['rows']['#vbo_confirm_form_title'] represents the first character of the string (see http://stackoverflow.com/a/7996961/328272) and the test result is TRUE if the string contains at least 1 character. In this case the first character is being set as the title and since this string often contains HTML, the HTML tag opening character < is used.

This bug was also noted by #2173259-8: Confirmation message not visible.

CommentFileSizeAuthor
#5 vbo-views-titles-2312547-5.patch710 bytesbennybobw
#1 views_bulk_operations-broken_titles-2312547-1.patch688 byteslmeurs

Comments

lmeurs’s picture

lmeurs commented
Priority: Normal » Major
StatusFileSize
new views_bulk_operations-broken_titles-2312547-1.patch688 bytes

Attached a patch.

lmeurs’s picture

lmeurs commented
Title: Views' titles are broken, they display ie. a < character » Broken view titles, they often only display a < character
bennybobw’s picture

bennybobw commented
Status: Active » Reviewed & tested by the community

We ran into this issue too, using the Media module, it breaks the media browser popup.

One note that this applies to php <= 5.3. Php 5.4 and above should be ok.

atracht’s picture

atracht commented

Thanks so much for finding this. It was hard to track down as I thought it was just a php 5.3 problem at first. Patch works fine for me

bennybobw’s picture

bennybobw commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new vbo-views-titles-2312547-5.patch710 bytes

I've now updated the patch to not use isset at all. This makes it more clear, since isset is such a tricky little beast.

maximpodorov’s picture

maximpodorov commented
Status: Needs review » Reviewed & tested by the community

The last patch fixes the problem.

pjbarry21’s picture

pjbarry21 commented

Patch in #5 worked for me, too.

nithinkolekar’s picture

nithinkolekar commented
Related issues: +#2329075: Views Title Not Displaying, +#2333951: Titles on views Pages are rendering as < (&lt;)

added related issues

elpino’s picture

elpino commented

Patch in #5 also worked for me.

thijsvdanker’s picture

thijsvdanker commented

Been hunting this bug all day and came to the same conclusion :)
+1 for the patch in #5!

  • bojanz committed 39ebd63 on 7.x-3.x authored by lmeurs 
    Issue #2312547 by bennybobw, lmeurs: Fixed Broken view titles, they...
bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Committed, thank you.
Gave commit credit to lmeurs since he did the initial bughunting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.