Simple issue, can't use rows classes, either via the UI (no field) or a preprocess.

Simple issue, simple fix, patch in first comment.

CommentFileSizeAuthor
#2 views_row_classes-6.x-1.13-1843166-2.patch1.51 KBdeciphered
#1 views_row_classes-1843166-1.patch1.63 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new views_row_classes-1843166-1.patch1.63 KB
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new views_row_classes-6.x-1.13-1843166-2.patch1.51 KB

Version for 6.x-1.13 (which the patch was originally based on).

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review

Forgot to mark as needs review (path #1 of course)

anarcat’s picture

anarcat commented
Status: Needs review » Reviewed & tested by the community

we're using those for the aegir project, they rock.

bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Doesn't this break compatibility with Views 2?

Anyway, if anyone is backwards enough to still use Views 2, they can stick to an earlier VBO release.
Committed, thanks.

roball’s picture

roball commented
Priority: Normal » Critical
Status: Fixed » Active

if anyone is backwards enough to still use Views 2, they can stick to an earlier VBO release.

Views 6.x-2.x is still the recommended version for D6! You cannot simply ignore those thousands of users being bound to use Views 6.x-2.x. If this commit breaks compatibility with Views 6.x-2.x, you should revert it so people can continue using VBO 6.x-1.x with Views 6.x-2.x, as advertised on VBO's project homepage:

Views 6.x-2.x works with VBO 6.x-1.x

bojanz’s picture

bojanz commented

You are right.
Patches welcome.
I haven't used Drupal 6 in years so I commit what the community wants.
(And yeah, I didn't know Views 6.x-3.x didn't have a recommended release, it seems it is just as unmaintained as VBO for D6)

roball’s picture

roball commented
Priority: Critical » Normal
Status: Active » Fixed

Good. At #2025215: _views_bulk_operations_hash_object() is not passed enough arguments in theme_views_node_selector, a user has just confirmed that 6.x-1.15+1-dev does work with Views 6.x-2.x.

roball’s picture

roball commented
Version: 6.x-3.x-dev » 6.x-1.x-dev

Actually, this was committed to 6.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.