I am sure a post somewhere explaining this but i couldn't find it.

Why was the nice, clean, little select all checkbox changed to a select list?

besides the fact the the new one is huge and wastes an inch of space on my table it also doesn't display item counts which really bites.

i guess the current rev is only beta.. so maybe still a chance to get the old perfect little checkbox back?? :)

Comments

mradcliffe’s picture

I am running to this as well on an OpenAtrium site. Commit 25f8c1779530ad24271ae9f4020718e81e374c6e changed this, but it is too big of a commit to just undo for that one change. I also found that the "all pages" option is broken with regard to filters.

I also found the following behavior/bug with this 6.x-1.1-beta1, which I can only blame this commit at the moment:
- selecting all rows on a page, either manually or via the select interface, results in 0 rows processed
- selecting all rows on all pages resulted in some filters applied but some not (username filter was applied, date filter as not)

Edit: unrelated issue with ajax views and vbo.

bojanz’s picture

I like the previous behavior as well, and I've kept it in the D7 port.
Unfortunately, this change can't just be reversed (even if infojunkie okay'ed it), and VBO for D6 is in maintenance mode (so pretty much no further commits unless critical or provided by the users themselves) so I can't really see this going away :/

Related: #1159040: Use a checkbox element header instead of a select element header in cases where unlimited rows is set..

echoz’s picture

I need the checkbox back also, for another use case - I have grouped fields, so select all checkbox used to check only all in the group, now the select dropdown, actually ruins the functionality by selecting all in multiple groupings, which this case would never want.

echoz’s picture

StatusFileSize
new8.14 KB

Here is a screenshot of my use case where the change from checkbox to select has reduced functionality. This shows the former VBO using a grouping field, where the "select all" checkbox will select all in only that group. The update, which is a required security update, with the select (dropdown) element to "select all", results in selecting all in all groups. The real world use of this never needs to check more than one grouping, but sometimes would use checking an entire group. This functionality would be lost.

If in fact infojunkie would not reverse this, can anyone provide a way I might re implement the select all checkbox?

blaiz’s picture

I don't like this change either. The issue for me is that I used to click on the checkbox and get the number of nodes that were selected. I created a view with a bunch of filters that I use to access my content, and publish new revisions in bulk. I like the fact that I could now how many nodes were in each of my categories, or how many were pending, or how many were in English and Italian, etc.

This option is now lost. And I also like to know the number of selected nodes because it provides visual feedback on how many will be affected. I think with that change it would be pretty easy to select Select All (All Pages) when we really only want the Current page, and have a change applied to too many nodes.

+ Small details, but I have a lot of columns on a small width, and having a select list makes the columns bigger than when it was a checkbox, which reduces the width of all other columns in the table, and adds too much whitespace next to each checkbox.

Please revert it back.

Thanks

echoz’s picture

Version: 6.x-1.11-beta1 » 6.x-1.11
Category: feature » bug

Changing to bug report since there is a loss of previous functionality.

joaomachado’s picture

StatusFileSize
new17.11 KB

Yes...this is a major irritation...if it didn't throw off the layout it would not be so bad. Functional, yes but aesthetically horrible!

joaomachado’s picture

StatusFileSize
new10.18 KB

I was wondering if there is any way to at least move the select list box into the Bulk Operations button section?
Although this does not satisfy the grouped select issue, it would at least move it out of the table header and fix the spacing issue.

echoz’s picture

@JoaoMachado, the related issue linked to in #2 has a patch to move the select above, if there are multiple pages (the existence of a pager). Perhaps this might coincidentally address your use case. As mentioned in that issue, you could also do that in a tpl file.

joaomachado’s picture

@echoz, thanks I must have missed that...

Uxi’s picture

Oh boy, this is really bad! That 'll teach me to mindlessly perform security updates without looking at the small print... :-(

I really need the node counting functionality of the previous "select all" checkbox behavior, not to mention the screen real estate of the table!

You can't be serious making such a huge drop in functionality and then leaving it like this...

bojanz’s picture

Seems like the biggest complaint is the lost "selected results" count, so maybe that can be patched in fast (having it at the top right corner above the table, for example).
There is still nobody actively working on the D6 version, so "be the change that you want to see in the world" (and VBO) :)

mradcliffe’s picture

No, I think the biggest complaint is that it's no longer mimics the standard UX for this sort of thing - a checkbox. Most programs display a checkbox for "select all" functionality.

infojunkie’s picture

Title: why did select all checkbox become select list » Bring back "select all" checkbox
Version: 6.x-1.11 » 6.x-1.x-dev
Status: Active » Fixed

Fixed in the latest dev. Reverted to older UI with some enhancements/simplifications. Please try it and comment here.

echoz’s picture

Thanks a lot @infojunkie for considering this fix.

This works fine for my use case, even though I need to hide the new (td) .views-field-select-all. My use case, described and shown above in #4, uses a grouping field. The select all checkbox now correctly selects only the one grouping, but controls and count in the .views-field-select-all row (shown in all groups) reflect all the groups for the count, but does not select the other checkboxes, and the radio buttons don’t get a selected state.

I don’t need anything in this row, so this is fine for me, but not sure if mine is that much of an edge case, that this shows it needs more work.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

goron’s picture

StatusFileSize
new23.25 KB

Here's a patch that encompasses the changes in the commit referenced above, which will apply cleanly to the current stable 6.x release (6.x-1.12). This can be used if you want to get back the 'select all' checkbox without updating to the dev version.

bojanz’s picture

So you create a patch that when applied to the stable version makes it the same as the -dev version (except with a few fixes less).
Pure genius.

goron’s picture

@bojanz - dev versions are not guaranteed to be stable, and change a lot. When using in a production environment, I'd rather get in just the fix I need and test just that on my site, then wait for the next stable version for the rest..

gstout’s picture

So I installed 6.x-1.13 to get the check box back, as stated here in the release notes.

#1280776 and others: Revert to select-all checkbox with some enhancements

But, I'm not seeing any check box? Is there a trick or a poorly documented setting?? Help

gstout’s picture

OK, I'm mistaken. I see it but it doesn't offer the select across page functionality. How do I get that back?