CommentFileSizeAuthor
#5 port_module_to_d8-2772603-5.patch8.55 KBsumitmadan
#3 port_module_to_d8-2772603-3.patch8.6 KBsumitmadan
#2 port_module_to_d8-2772603-2.patch8.64 KBsumitmadan

Comments

sumitmadan created an issue. See original summary.

sumitmadan’s picture

sumitmadan commented
Status: Active » Needs review
StatusFileSize
new port_module_to_d8-2772603-2.patch8.64 KB
sumitmadan’s picture

sumitmadan commented
StatusFileSize
new port_module_to_d8-2772603-3.patch8.6 KB
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Needs review » Needs work

Good job with the patch! Small nitpicks listed below:

  1. +++ b/src/Plugin/views/access/ViewsAccessCallback.php
@@ -0,0 +1,117 @@
+use Drupal\user\PermissionHandlerInterface;

    Why is this needed? 

  2. +++ b/views_access_callback.info.yml
@@ -0,0 +1,7 @@
+dependencies: ¶

    Extra space at the end of line.

sumitmadan’s picture

sumitmadan commented
StatusFileSize
new port_module_to_d8-2772603-5.patch8.55 KB

Thanks Ajit. Updated patch accordingly.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Title: Port module to D8 » Port Views Access Callback to D8
Status: Needs work » Reviewed & tested by the community

Looks good. Thank you!

maciej.zgadzaj’s picture

maciej.zgadzaj commented
Status: Reviewed & tested by the community » Fixed

Thanks Sumit! Committed and pushed to d.o.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.