Closed (fixed)
Project:
Views (for Drupal 7)
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2009 at 18:02 UTC
Updated:
17 May 2011 at 15:32 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerCould you create a patch? This does really helps what you are doing here.
I think this can be added but
has tabs instead of spaces :)
Comment #2
gazzer82 commentedHi Guys,
All i can say is thankyou, thankyou, thankyou!! I have been banging my head against a brick wall for hours trying to open a node linked from views in a lightmodal box and this combined with a custom page.tpl.php has it working beautifully!
Thanks
Gareth
Comment #3
texas-bronius commentedI'm on 6.x.2.8: What file(s) does this patch in the later version? Or was the original file broken into the 7 or so views_handler_field_node_*.inc that I see in /modules/views/views/modules/node? I tried just dropping it in that folder, and no dice for me.
Comment #4
dawehnerHere is a real patch for it.
Comment #5
dawehnerHere is a update
Comment #6
mrconnerton commentedHas anyone tested the patches to make sure they work and are good for production?
Can we get this commited?
Comment #7
dawehner@mrconnerton
If you want to have this patch commited i suggest you to
a) Test the patch
b) Look at http://drupal.org/project/issues/views?text=&status=8&priorities=All&cat...
and decide that this patch is much more important than every other one :)
Comment #8
mrconnerton commentedI have tested this today and seems to work great. I'm using views 2.11
Comment #9
dawehnerSo please review the patch and change the status if it's fine :)
Thanks!
Comment #10
mrconnerton commentedMy only note would be the help text "Include Rel attribute for use in lightbox2 or other javascript utility" should be more generic? There are many use cases for rel that we don't need to make a lightbox2 specific reference.
Comment #11
agileware commentedAlso, I would recommend actually testing the patch before setting to RTBC!
See http://drupal.org/node/156119
The current patch puts the class attribute in the rel attribute.
This patch fixes that.
Comment #12
agileware commentedChanging version.
Comment #13
merlinofchaos commentedCommitted to all branches.
Comment #14
mmilo commentedErm, this issue says that this is for Views2 - however, it seems that this patch was committed to Views3 instead.
Any chance we can have this committed to Views2 as well?
Thanks!
Comment #15
dawehnerThis is part of views 2.x, but isn't part of views 2.12.
Comment #16
datawench commentedI have downloaded 2.x-dev, in which I see this patch in place, and I see no difference. The rel attribute is simply not being rendered.
Comment #18
yan commentedTested 6.x-2.x-dev and it works fine. But is there ever gonna be a 6.x-2.13 release?