Hi.. I added a rel field in the 'Output this field as a link' form for use with lightbox2/ thickbox. It allows for use of tokens/ links in the lightbox2 image captions, which is what I needed. Merlin, are you interested in having this added to views2?

I added the patches in views_handler_field.inc starting on lines 241 and 539.

Comments

dawehner’s picture

Category: task » feature

Could you create a patch? This does really helps what you are doing here.

I think this can be added but

<?php
	$rel = $this->options['alter']['rel'];
	$rel = strtr($rel, $tokens);
	if($rel){
		$options['attributes']['rel'] = $rel;
	}

has tabs instead of spaces :)

gazzer82’s picture

Hi Guys,

All i can say is thankyou, thankyou, thankyou!! I have been banging my head against a brick wall for hours trying to open a node linked from views in a lightmodal box and this combined with a custom page.tpl.php has it working beautifully!

Thanks

Gareth

texas-bronius’s picture

I'm on 6.x.2.8: What file(s) does this patch in the later version? Or was the original file broken into the 7 or so views_handler_field_node_*.inc that I see in /modules/views/views/modules/node? I tried just dropping it in that folder, and no dice for me.

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new1.25 KB

Here is a real patch for it.

dawehner’s picture

StatusFileSize
new1.25 KB

Here is a update

mrconnerton’s picture

Has anyone tested the patches to make sure they work and are good for production?

Can we get this commited?

dawehner’s picture

@mrconnerton

If you want to have this patch commited i suggest you to

a) Test the patch
b) Look at http://drupal.org/project/issues/views?text=&status=8&priorities=All&cat...
and decide that this patch is much more important than every other one :)

mrconnerton’s picture

I have tested this today and seems to work great. I'm using views 2.11

dawehner’s picture

So please review the patch and change the status if it's fine :)
Thanks!

mrconnerton’s picture

Status: Needs review » Reviewed & tested by the community

My only note would be the help text "Include Rel attribute for use in lightbox2 or other javascript utility" should be more generic? There are many use cases for rel that we don't need to make a lightbox2 specific reference.

agileware’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.28 KB

Also, I would recommend actually testing the patch before setting to RTBC!
See http://drupal.org/node/156119

The current patch puts the class attribute in the rel attribute.

This patch fixes that.

agileware’s picture

Version: 6.x-2.6 » 6.x-2.x-dev

Changing version.

merlinofchaos’s picture

Status: Needs review » Fixed

Committed to all branches.

mmilo’s picture

Status: Fixed » Patch (to be ported)

Erm, this issue says that this is for Views2 - however, it seems that this patch was committed to Views3 instead.

Any chance we can have this committed to Views2 as well?

Thanks!

dawehner’s picture

Status: Patch (to be ported) » Fixed

This is part of views 2.x, but isn't part of views 2.12.

datawench’s picture

I have downloaded 2.x-dev, in which I see this patch in place, and I see no difference. The rel attribute is simply not being rendered.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yan’s picture

Tested 6.x-2.x-dev and it works fine. But is there ever gonna be a 6.x-2.13 release?