Change notice: Views Attachments aren't rendered anymore

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayAttachmentTest.phpundefined
@@ -0,0 +1,59 @@
+  public function testAttachment() {

Should be protected ;)

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayAttachmentTest.phpundefined
@@ -0,0 +1,59 @@
+    // @todo Try to understand why the initial loading doesn't rebuild the menu
+    // cache.

Isn't this #1828444: Display Plugin doesn't register menu entries on the first request in simpletest? If so it could link to it. Also, multiline @todo's should have the second line indented 2 more spaces

#3: durpal-1861852-3.patch queued for re-testing.

While that retests (random failure), I'm going to see if I can improve the test some.

Hm, turned out I couldn't do much, just fixed the docblock.
I'd RTBC but I like following the rules.

+++ b/core/modules/views/theme/theme.incundefined
@@ -96,8 +96,18 @@ function template_preprocess_views_view(&$vars) {
+  if (!empty($view->attachment_before)) {
+    $vars['attachment_before'] = $view->attachment_before;
+  }
+  else {
+    $vars['attachment_before'] = '';
+  }
+  if (!empty($view->attachment_after)) {
+    $vars['attachment_after'] = $view->attachment_after;
+  }
+  else {
+    $vars['attachment_after'] = '';
+  }

I guess this is for performance reasons, which is cool. We should default this to an empty array() though and not a string.

Otherwise this patch is lookin' goood.

Nice, as long as this is green. Don't see why it wouldn't be.

Committed to 8.x. And thanks for adding tests!

Moving to views for the change notice.

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447