Replace CTools collapsible-div with a simple solution

Sounds good.

Just working on this now.

This converts the CTools collapsible-div stuff to views, and removes anything to do with the states/cookies. Is this what we're after? or do we want an new 'simple' solution? To me, this is the simplest solution, as we have the code already.

The patch doesn't include the collapsible-collapsed.png and collapsible-expanded.png files, which we would need to move over too.

Oh, and how about the patch!

I have also moved over the theme function (views_collapsible) too. In the hope we can refactor some of the code in views_ui to just use this instead of how it does it currently - good followup issue.

How about this instead?

And removed more stuff...

Remove some more un needed css stuff

With the images in the diff.

+++ b/css/collapsible-div.cssundefined
@@ -0,0 +1,26 @@
+.views-collapsible-container .views-toggle {

Just wondering what happened with the RTL css code, can we simply get rid of them, important i have no glue of css.

Nice cleanup of all this code!

I added the rtl code back in, as well as the other css. As we need this to make it look as it does currently in views. Here is (what I think) is a better version!

One more...

Assigning to myself for CSS polish.

Work summary:

• Removed the parent collapsible div
• Used CSS borders instead of images for the arrow (like the dropbutton)
• Changed the markup for the toggle arrow so that it is a link and picks up the link color
• Added back the export filter styling that was removed by accident because it was in the collapsible div comment block
• Added in RTL support
• Removed 'Advanced' text when there is no js because the default position is open

Rerolled.

I did talk about using a fieldset right from the start, but we had some other stuff in the collapsible-div then (like states). So now, I guess there is not really much reason for us not to use a fieldset? Would need to be re themed though :)

On the plus, we would save much more code again. I like what we have now, it seems a bit overkill though. The only main difference in the old collapsible-div is the states....

ok, here is a quick patch to ditch everything so far.... :(

Much less code, fieldsets, some other logic around the collapsible can be removed too. I think this makes a much simpler read already.

@dead_arm: So... how do you feel about some more theming work using this instead?

Yay! Assigning to myself for CSS stuff.

Removed the parent fieldset, cleaned up the CSS for all three themes, checked and updated the RTL sheets.