Cleanup pagers: Store pagers on the same levels as query [#1751294]

Comment	File	Size	Author
#8	1751294-pager-view-8.patch	14.64 KB	dawehner
#1	1751294-pager-view.patch	14.65 KB	dawehner

Comment #1

German

commented 26 August 2012 at 08:08

Status	File	Size
new	1751294-pager-view.patch	14.65 KB

.

Log in or register to post comments

Comment #2

aspilicious commented 26 August 2012 at 08:14

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

26 August 2012 at 08:17

Status:

Needs review

» Needs work

The last submitted patch, 1751294-pager-view.patch, failed testing.

Log in or register to post comments

Comment #4

aspilicious commented 26 August 2012 at 08:42

+  use Drupal\views\Plugin\views\pager\Full;
+  if ($view->pager instanceof Full && $cache->options['type'] == 'time' && count($view->result) < 10) {

use statements should be on top of the file, just behind the namespace stuff

Log in or register to post comments

Comment #5

lunaris commented 26 August 2012 at 09:22

-        if ($this->pager->use_count_query() || !empty($view->get_total_rows)) {
-          $this->pager->execute_count_query($count_query);
+        if ($view->pager->use_count_query() || !empty($view->get_total_rows)) {
+          $view->pager->execute_count_query($count_query);

You've changed "this" to "view" here (and throughout the class in question); is this correct?

Log in or register to post comments

Comment #6

aspilicious commented 26 August 2012 at 09:23

yes thats correct

Log in or register to post comments

Comment #7

dawehner

German

commented 26 August 2012 at 09:30

Status:

Needs work

» Needs review

+  use Drupal\views\Plugin\views\pager\Full;
+  if ($view->pager instanceof Full && $cache->options['type'] == 'time' && count($view->result) < 10) {
use statements should be on top of the file, just behind the namespace stuff

I agree in theory but shouldn't this be done like that in api documention? It would be cool to discuss that.