I did an experimental patch. Wanted to know how module dependencies get handled :)

More information: http://drupal.org/node/1710766

CommentFileSizeAuthor
#11 views-1711640-11.patch9.8 KBtim.plunkett
#8 1711640-8.patch9.72 KBdamiankloip
#6 1711640-6.patch9.75 KBdamiankloip
0001-convert-setup-calls.patch9.94 KBaspilicious

Comments

Status: Needs review » Needs work

The last submitted patch, 0001-convert-setup-calls.patch, failed testing.

aspilicious’s picture

aspilicious commented
Issue tags: +VDC

added tag

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
Issue tags: -VDC

0001-convert-setup-calls.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 0001-convert-setup-calls.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

This should be rerolled with the docblocks we agreed on for core.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1711640-6.patch9.75 KB

re rolled with these changes in.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

There should be a blank line after the class before the first comment.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1711640-8.patch9.72 KB

Oops, here you go.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -VDC

#8: 1711640-8.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 1711640-8.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new views-1711640-11.patch9.8 KB

ViewsSqlTest was enabling views_ui already, so we are able to remove it from its child classes.

damiankloip’s picture

damiankloip commented

Nice.

aspilicious’s picture

aspilicious commented 
+++ b/lib/Drupal/views/Tests/PagerTest.phpundefined
@@ -21,10 +22,6 @@ class PagerTest extends ViewsSqlTest {
-    parent::setUp('views', 'views_ui', 'views_test');

what about views_test?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

PagerTest::setUp() passed "views_test", but its parent is ViewsSqlTest::setUp(), which completely ignored its child classes and only enabled views and views_ui anyway. So the module was never used by the test.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

in that case...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/views.git/commit/e0e125c

Automatically closed -- issue fixed for 2 weeks with no activity.