Error getting relationship handler label from non-object. [#1011266]

When I add any type of relationship, I get an ajax error due to an issue in admin.inc getting the label of the relationship handler. Two snapshots attached.

There is a @todo in the code // @todo: get_handlers() but since this is breaking relationships unnecessarily I figured I would have a stab at the correct fix, at least to circumvent the problem for ourselves. Patch supplied.

I've tagged this "major" because when you add a relationship you break aspects of the views UI and have to delete the view to remove the relationship.

File	Size	Author
admin-handler-label.patch	789 bytes	sime
taxonomy-node-relationship.jpg	112.63 KB	sime
node-author-relationship.jpg	158.46 KB	sime

Comments

Comment #1

Scott Reynolds commented 31 December 2010 at 06:40

Priority:	Major	» Critical
Status:	Needs review	» Reviewed & tested by the community

Thanks for the patch. worked great. Critical as relationships don't work period without this.

Comment #2

dawehner

German

commented 31 December 2010 at 08:29

Isn't this the same issue as #759082: Invalid argument supplied for foreach in admin.inc line 1296 ?

The fix look a bit different here.

Comment #3

Scott Reynolds commented 31 December 2010 at 09:18

Ya they are the same but 7-3 and 6-3 seem out of sync right here. Should take the time to rectify that situation. i.e. patch in #759082: Invalid argument supplied for foreach in admin.inc line 1296 won't apply because in the D7 port does call views_get_handler, and it already uses $display->handler->get_option('relationships');