this appears in the modules list of a fresh drupal install, with cck and views enabled. Is there a quick fix?

CommentFileSizeAuthor
#3 viewreference.patch548 bytesplj

Comments

g10’s picture

Status: Active » Fixed

seems the following line is missing in the .info file:
core = 6.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

plj’s picture

Component: Miscellaneous » Code
Category: support » bug
Priority: Normal » Critical
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new548 bytes

The simplicity of the problem is no reason to leave it unfixed! Patches are required for even simple mistakes!

I upgraded multiple modules on a certain site and then wasted nearly three hours trying to figure out where the problem was after I'd got complaints that information was missing on certain pages; I hadn't built those views, so I didn't understand that View Reference was necessary, and hadn't realised this error, since I hadn't looked into the list of installed modules (modules don't usually disable themselves during updates).

Patch attached; it is against DRUPAL-6--2, i.e. the “dev” tag (I don't know why can't I select that version here). As it is very obvious, I doubt it needs any further testing.

In its current form the 6.x-2.21 cannot be used without manual fixing, so I think this issue should warrant an immediate new release.

danielb’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I cannot replicate the problem you are having? I don't understand, your patches just adds in something that is already there :/
I just downloaded it - the line is not missing from the file.

danielb’s picture

This issue bugs me because I see in my other modules the core line is there twice, once added by me, once by the packaging script. Weird I don't get it. I must have removed it during a CVS update thinking there was redundancy.

But this doesn't explain why the module works for me (and others) when I download and install it, but not for you two.

plj’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

The reason is most likely that we both have checked out the code from the CVS, instead of downloading a tarball. Try to check out the module to an empty directory, and then check the contents of the newly checked out .info file; the line is simply not there.

Packaging script adds the into the file, and that's why it works for you—but, one should be able to maintain a Drupal installation directly from CVS.

danielb’s picture

Status: Reviewed & tested by the community » Fixed

oh thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.