Hi,

i your access list you only show content type by module "node", but for all other types like "forum" or "webform" access is restricted by default too, and there is no option to get access back...

regards pebosi

CommentFileSizeAuthor
#4 all_nodetypes.patch645 bytespebosi

Comments

djuba’s picture

Status: Active » Postponed (maintainer needs more info)

hi!

first of all, you can uninstall module, rebuild your permissions and all will be ok with your rights. There are no access management module, which influence can't be undone.

second
do you check "access content" permission?

can you provide screenshot with permissions for forum module and node module?

webchuck’s picture

Djuba,

I noticed in view_own.module, line 33, that permissions are only set for modules of type 'node'. This restriction keeps other modules, like webform and blog, from being displayed. By removing the restriction the module will work for all content types.

Unfortunately, I don't know how to make a patch, so I'll just show the changes I made here:

Original code:

function view_own_perm() {
  foreach (node_get_types() as $type) {
    if ($type->module == 'node') {
      $perms[] = 'view own '. $type->type .' content';
      $perms[] = 'view any '. $type->type .' content';
    }
  }
  return $perms;
}

Updated code:

function view_own_perm() {
  foreach (node_get_types() as $type) {
    $perms[] = 'view own '. $type->type .' content';
    $perms[] = 'view any '. $type->type .' content';
  }
  return $perms;
}

If there's a good reason to restrict this access to types of module "node" please let me know. Otherwise, please update the module so it will work with all content types.

Chuck

AltaVida’s picture

I agree with #2. I don't understand why this module can't be used with nodes created by blog.module, image.module or others.

pebosi’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new645 bytes

Created a patch for that, only removes the if statement

regards

farald’s picture

Subscribing
Hope this gets implemented soon:)

kenorb’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SageOfCode’s picture

Thank you(!) for fixing this. I just ran into the same bug.
I just have two questions:

1. The fix was committed on: May 27, 2009.
Therefore, it looked like the development snap shot: 6.x-1.x-dev 2009-May-30, has this committed fix. Correct?

2. The current released version is: 6.x-1.1 2008-Sep-04.
Do you know when the nest released version will be?

Thank you in advance.

royerd’s picture

I've had to use the DEV version in order to get Blog permissions to work correctly. Without dev version and its patch, you can't use the blog content type. Why not create a new release--this seems kind of critical.

mckeen_greg’s picture

Status: Closed (fixed) » Active

This is also very important if you have your Content Types moved into Features.

Please ensure this is updated in the new release.

kenorb’s picture

Status: Active » Fixed

Created:
view_own 6.x-1.2-rc1
http://drupal.org/node/1235552

Clint Eagar’s picture

Just installed 6.x-1.2-rc1 and the if ($type->module == 'node') { still exists.

Clint Eagar’s picture

Version: 6.x-1.1 » 6.x-1.2-rc1
Status: Fixed » Needs review

Changed status to "needs review"

jksloan2974’s picture

Does anyone know if line 32 of the view_own.module file will be changed to the following to include content types added to features?

if (($type->module == 'node') || ($type == "features")) {

kenorb’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

Version 6.x is no longer supported due to Drupal 6 End of Life.