Problem/Motivation

Through #3520999: Unable to edit the formatter settings (Warning: Trying to access array offset on null in Drupal\field_ui\Form\EntityDisplayFormBase->copyFormValuesToEntity()) and https://git.drupalcode.org/project/leaflet/-/commit/099db9b I saw that the methods in the formatters / Trait are missing the parent:: calls in all relevant functions!

This is important because we lose their implementation, at least if they change.
Sadly that does not fix the parent issue, but should also be fixed and I think the Trait would be the right place, combined with #3521016: VidstackPlayerFormatterTrait::getSharedSettings() should be called ::settingsForm()?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork vidstack_player-3521021

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil’s picture

grevil commented

We can not use the Trait unfortunately, as it doesn't implement "settingsForm" as stated there. But I agree, this should be fixed.

grevil opened merge request !3

grevil’s picture

grevil commented
Status: Active » Needs review

Done, please review!

grevil’s picture

grevil commented

Re!

grevil’s picture

grevil commented
Title: Formatter functions are missing the FileMediaFormatterBase parent:: calls » Add parent calls, adjust templates and fix formatter settings
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Great!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

  • anybody committed 4ec045d1 on 1.x authored by grevil 
    Issue #3521021: Add parent calls, adjust templates and fix formatter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.