Problem/Motivation

I just reviewed the trait code and I think for best practice trait implementation VidstackPlayerFormatterTrait::getSharedSettings() should be called ::settingsForm() and same for ::getSharedDefaultSettings?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Parent issue: » #3520999: Unable to edit the formatter settings (Warning: Trying to access array offset on null in Drupal\field_ui\Form\EntityDisplayFormBase->copyFormValuesToEntity())
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Closed (works as designed)

The problem is, that the settings are not the same for both Formatters. Meaning we would need to rename the "settingsForm" method on import for one of them anyway.
We should leave it as is.