Problem/Motivation

Test upgrade path to 10.x from current 3.x and document the steps to take.

We should ensure it generally still works as expected, but of course major upgrades may contain substantial changes. At least we'll have major template changes, which can't be circumvented by design.

I'd vote for an update hook informing users and a section in the README.md.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork videojs-3617090

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

grevil’s picture

Title: Test and document upgrade path to 10.x » [10.x] Test and document upgrade path to 10.x
Assigned: grevil » Unassigned
anybody’s picture

I think we should see this as alpha release blocker. If I got @grevil correctly, this SHOULD already be fine.

We also already have an update hook: https://git.drupalcode.org/project/videojs/-/blob/10.x/videojs.install?r...

Please also add some upgrade information on the module page, README.
Please add a sentence to the update hook that templates have breaking changes so output and possible overrides should be checked?

grevil’s picture

Title: [10.x] Test and document upgrade path to 10.x » [10.x] Implement and test upgrade path to 10.x
grevil’s picture

Status: Active » Postponed

Alright, works as expected! Tested it for both fields using layout builder and without! Works like a charm! :)

I guess we should finally discuss #3619644: [10.x] The merge plugin is discouraged and should not be used before merging this (since the prefered installation instruction message will show up, if the user has cdn disabled).

NOTE, that the old "videojs_player" formatter was never really used because of a bug. Instead old installations always used the "videojs_player_list" formatter (Video.js Player with fallback sources). But that should stay as is.

POSTPONED on #3619644: [10.x] The merge plugin is discouraged and should not be used, otherwise good to go! :)

grevil’s picture

Status: Postponed » Reviewed & tested by the community

The related issue is fixed now. We can safely merge this!

  • grevil committed 8f628bf1 on 10.x
    task: #3617090 [10.x] Implement and test upgrade path to 10.x
    
grevil’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.