Problem/Motivation

Currently, each version of the module tends to be coupled with a specific Video JS library version. The current version is set to load v5.x of the module, there is talk of updating to v10. etc. The module also enforces CDN delivery of the library itself.

Based on some of the logged feature requests it would be really beneficial to provide a level of flexibility in how the VideoJS library is delivered. The befits of this approach are:

  • decouples the module and the underlying library - both can be updated/maintained independently (to a degree),
  • allows to keep the module up to date while maintaining preferred version of the library,
  • allows to choose the desired version of the library (for compatibility/feature reasons etc),
  • allows to self-host the library locally, or install the library via composer independently of the module.

Steps to reproduce

  • Install the module,
  • Observer the lack of options supporting the source or version selection.

Proposed resolution

  • Add configuration form that allows to choose library version and location,
  • Add permissions to limit the access to the form,
  • Add dynamic library resolution to support local/cdn delivery, based on the configs,
  • Align runtime requirements check with the selected configuration.

Remaining tasks

  • [ ] Evaluate feature request
  • [ ] Add/change requirements or desired features
  • [ ] Implement
  • [ ] Review / test

User interface changes

Adds configuration form

API changes

None

Data model changes

None

Issue fork videojs-3592097

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

euk created an issue.

euk changed the visibility of the branch 3592097-provide-flexible-library-3.1.1 to hidden.

euk changed the visibility of the branch 3592097-provide-flexible-library to hidden.

euk changed the visibility of the branch 3592097-provide-flexible-library-3.1.1 to active.

euk changed the visibility of the branch 3592097-provide-flexible-library-3.1.1 to hidden.

euk changed the visibility of the branch 3592097-provide-flexible-library to active.

euk’s picture

Sorry for the noise. Here are some details:

  • MR16 is the proposed updates.
  • MR17 is for generating a patch against the current 3.1.1 tag