[10.x] Prepare 10.x branch for Video.js 10 implementation

Hi,
I need this fairly urgently.
I will thus work on an implementation for Video.js 10 in a fork and will submit an MR soon.

Yes. I saw that :)
I submitted a feature request to include dist files as GitHub release assets to be able to use them as library files in the drupal module.
I will use the CDN files for now.

I just pushed a first commit to the 4.x branch that uses the CDN files.
The commit also adds support for audio files.

Why not create a Draft MR against 3.x and switch over to 4.x once it was created? I did that.

So we can better review and comment the code.

@yannickoo I think we should push things forward here. You've done a great job, would you maybe like to try contacting the current maintainers about their VideoJS 10 and 4.x plans and maybe offer (Co-)maintainership?
We as DROWL team would also like to help if the maintainers are not planning to push this forward. I'd like not to do a fork for that, but didn't see maintainer activity here yet.

@semiaddict I guess you're also interested?

Just worte @_shy a message asking for further plans:

Hi Kostia,

hope you're fine.

Just wanted to reach out and ask about your plans for VideoJS 10: https://www.drupal.org/project/videojs/issues/3577815
Are you still actively maintaining the module?

Would you mind commenting the issue and share your plans and maybe create a 4.x branch or 10.x branch (to keep it in sync with Video.js) to work on?

Thanks a lot!

Julian

I'd vote to have the branch in sync with videojs branch, so let's use 10.x

Hi guys, thanks for your contribution.

I created a new 4.x branch so we can work with that now. Moved the MR from the Draft state.

Hi @_shy, thanks! Would you accept to use a 10.x branch instead to keep it in sync with the library version this module is based on, for the future?

For library-focused / based modules that makes a lot of sense, because it makes it a lot easier to understand and maintain to keep things in sync. So if VideoJS 11 contains braking changes (due to SemVer) we can simply solve this in 11.x etc.
A really helpful pattern.

Maybe you can still delete 4.x then and make 10.x the default in GitLab?

Hi @anybody!

Yes, I agree it makes sense for me. Let's use 10.x branch instead.

Thank you so much @_shy! @grevil will start working here right now!

Yes already on it. Created a seperate branch and used the work from @yannickoo and @semiaddict as a base.

Reviewing the current status, thanks @grevil!!

Nice work @grevil - left my comments! :)

As discussed we should maybe move the dialog parts into the dedicated follow-up. At least the XHTML part, which doesn't look complete anyway.

All green! I think this is ready to merge @anybody?

The rest of the features / follow-ups will be done in the other issues

Thanks @grevil great work! Let's merge this and keep 10.x releases in an alpha state for quite a while!
Let's proceed in the follow-ups.

@anyone reading this: Please help us testing and provide feedback!

Thanks @grevil great work! Let's merge this and keep 10.x releases in an alpha state

We shouldn't release anything for now until the remote formatter and poster works correctly.