Even though I try to click the Zencoder radio button under Transcoders, the code is always validating settings for ffmpeg_wrapper, I printed out the $transcoder variable and it never takes the zencoder value from the form.

Also, I'm getting the curl connection error again, where it cannot verify the ssl certificate of a server.

Comments

hypertext200’s picture

I think that because of the your old trancoder is ffmpeg_wrapper, what you can do is change default transcoder to ffmpeg and do upgrade.

justageek’s picture

I'm not sure what you mean, all I did was install the alpha code for the first time, we did not even have an older version installed, so the alpha did not work "out of the box"

hypertext200’s picture

Do #990576: cURL connection error (60): SSL certificate problem, verify that the CA cert is OK. Details: error:14090086:SSL routines:SSL3_GE for CURL connection issue.

If you already had video instaled then before you replace the code, go to your settings and change the ffmpeg_wrapper to ffmpeg or Zencoder.

m.sant’s picture

If you already had video instaled then before you replace the code, go to your settings and change the ffmpeg_wrapper to ffmpeg or Zencoder.

In my case before updating the transcoder was set to ffmpeg and the module ffmpeg_wrapper was disabled. Nevertheless the transcoder page is broken:

Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job() must be compatible with that of transcoder_interface::load_completed_job() in /home/......../sites/all/modules/video/transcoders/video_ffmpeg_wrapper.inc on line 12

I'm not sure that the issue #990602: Fatal error in the transcoders settings page after updating is a duplicate of the current one, as the problem reported by justageek doesn't prevent the transcoders page from being displayed (he can still click the radio buttons) and he didn't receive any fatal error.

The error message I receive says that the ffmpeg_wrapper implementation of the transcoder_interface is wrong (file transcoders/video_ffmpeg_wrapper.inc). If I remove "implements transcoder_interface" on line 12 of video_ffmpeg_wrapper.inc the transcoder page comes back in place.

Thanks,
Marco

hypertext200’s picture

@m.sant, please remove all the existing files and copy new video folder there.

m.sant’s picture

I've done it and the transcoders page is back.

The problem now is that, even though the ffmpeg_wrapper is now enabled, it is not possible to select the ffmpeg_wrapper anymore (no radio button). The only option I have now is "Locally Installed Transcoders (FFMPEG/Handbreke/Mcoder)".

Furthermore the default transcoder (ffmpeg) has no option to insert custom command options (as in the previous version), therefore it is impossible to use the library vhook to add a warermark.

Thanks for the quick reply,
Marco

hypertext200’s picture

Status: Active » Fixed

@m.sant, you can use your own code as previous version, in this version you will have to find video_preset folder and edit presets there, or you can create your own presets.

Now you can use commands as much as you want.

m.sant’s picture

Ok, now the conversion works if I create a new preset containing the desired options: the original file is saved in the sites/default/files/videos/original folder and the converted file is saved in the sites/default/files/videos/converted folder as expected. I think that this should be documented somewhere, as well as the fact that the ffmpeg_wrapper is not supported anymore (the project page states that it is supported).

Unfortunately I get another error message right after the conversion process ends:

user warning: Unknown column 'filepath' in 'field list' query: SELECT filepath FROM video_files WHERE fid=712 in /home/....../sites/all/modules/video/transcoders/video_ffmpeg.inc on line 404.

Any thoughts on this?

Should I open another issue about it?

Thanks,
Marco

PS

mysql> SHOW CREATE TABLE video_files;

CREATE TABLE `video_files` (
  `vid` int(10) unsigned NOT NULL auto_increment,
  `fid` int(10) unsigned NOT NULL default '0',
  `nid` int(10) unsigned NOT NULL default '0',
  `dimensions` varchar(255) default '',
  `status` int(10) unsigned NOT NULL default '0',
  `started` int(11) NOT NULL default '0',
  `completed` int(11) NOT NULL default '0',
  `data` longtext,
  PRIMARY KEY  (`vid`),
  KEY `status` (`status`),
  KEY `file` (`fid`)
) ENGINE=MyISAM AUTO_INCREMENT=85 DEFAULT CHARSET=utf8
m.sant’s picture

It seems that line 404 of transcoders/video_ffmpeg.inc tries to perform the wrong query to retrieve the file to be deleted. The correct one should be:

    $sql = db_query("SELECT filepath FROM {files} WHERE fid=%d", $video->fid);

Thanks,
Marco

asb’s picture

Status: Active » Needs work

Same issue here; I got the Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job()... error when deleting (!) a non-video related node, so this issue affects the functionality of Drupal core. #9 seems to fix this problem; it would nice to have a proper patch file for this.

However, accessing ./admin/settings/video/transcoders fails with the following error:

Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job() must be compatible with that of transcoder_interface::load_completed_job() in /var/www/drupal/sites/all/modules/video/transcoders/video_ffmpeg_wrapper.inc on line 12

Also there's another issue: alpha2 also breaks Cron. This can be easily reproduced with Drush. Error message:

# drush cron
Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job() must be compatible with that of transcoder_interface::load_completed_job() in /var/www/amoenus/sites/all/modules/video/transcoders/video_ffmpeg_wrapper.inc on line 12
Drush command could not be completed.                                                                                                                                             [error]
WD cron: Cron run exceeded the time limit and was aborted.

Workaround: Prevent 'Vide' module to use Cron at by unchecking "Use Drupals built in cron" at ./admin/settings/video/cron. This also affects the functionality of Drupal core, so this still has priority "critical".

Greetings, -asb

asb’s picture

Title: Alpha code broken? where is stable 4.x release? » Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job()
Status: Fixed » Active
hypertext200’s picture

Status: Needs work » Fixed

@asb, if you were using ffmpeg_wrapper then change it to ffmpeg first and then upgrade the module, otherwise you'll need to reset it by database.

asb’s picture

Status: Fixed » Active

Since I'm experiencing these error I obviously already have upgraded the module, that's the point of my issue report, isn't it?

Sorry, I can not see why you consider this issue as fixed. There is neither a new release nor a patch for the most recent one; the configuration page ./admin/settings/video/transcoders is inaccessible, thus I can not change the transcoder from ffmpeg_wrapper to ffmpeg; and I have not the faintest idea how to "reset it by database" (do what in which database?). To my understanding such database operations should be done with database updates, and that's why I'm running ./update.php after every module update, right? There is not even a warning on the project page that prerequisits might be required when updating the module, and ffmpeg_wrapper is still listed as supported.

hypertext200’s picture

@asb you can install RC6 module and then change the ffmpeg_wrapper transcoder, in release note I clearly mentioned this.

asb’s picture

you can install RC6 module [...]

What is "RC6 module"? Is this a module's name or a module's version ("Release Candidate 6")? The project page for the 'video' module currently lists seven releases for download: (1) 6.x-4.2-alpha2, (2) 5.x-1.5, (3) 4.7.x-1.0, (4) 6.x-3.9, (5) 6.x-2.9, (6) 7.x-1.x-dev, and (7) 6.x-4.x-dev. I can not find a "RC6" here.

in release note I clearly mentioned this.

What release note? The README.TXT which came with video-6.x-4.2-alpha2 from December 4th 2010 says:

# more README.txt 
// $Id: README.txt,v 1.8.4.5.4.5.2.4 2010/07/10 04:02:19 heshanmw Exp $
------------

 to embed videos into drupal pages, using CCK and filefield support.
This module add the possibility to create video nodes which are containers
 to embed videos into drupal pages, using CCK and filefield support.

For information about supported file types see FILE_TYPES.txt
http://video.heidisoft.com/content/welcome-video-module-documentation

For general instructions read video.module handbook:
http://video.heidisoft.com/content/features

Please submit bugs/features/support requests at:
  http://video.heidisoft.com/content/welcome-video-module-documentation
  http://video.heidisoft.com/contact


Maintainers
-----------

        Heshan Wanigasooriya :heshan at heidisoft dot com, heshanmw at gmail dot com
  Dennis : http://drupal.org/user/384543
  Glen Marianko : http://drupal.org/usr/527446 http://linkedin.com/in/glenergetic twitter: @glenergetic

I can not find any information regarding update prerequisites in this text. There is also a file INSTALL.txt which does not include update instructions, either.

Also I'd like to add that users upgrading through Drush won't see none of these texts before running the update.

hypertext200’s picture

See http://drupal.org/node/988786

HTML5 Support.
Multiple video output from single video upload.
Multiple transcoder support.
Configurable transcoding presets.

Important : Note to update
-----------------------
We have slightly changed the database schema so, if you upgrade module make sure you backup all the video_files, video_s3, video_zencoder tables. Cause this will remove some unwanted fields and add new. You will have to run a separate script to load old data or do below.

We discontinues the ffmpeg_wrapper support so if your a ffmpeg_wrapper user then change transcoder to Zencoder or Ffmpeg before upgrade.

Another important thing is for existing users is, please re-check the configurations of the video module and if anythings are missing.

TODO : To upgrade videos module, the easiest way is configure module properly and upload a new video and test if its working. Then go to video_files (FFMPEG) or video_zencoder (Zencoder) tables and let them convert again by changing status to 1
asb’s picture

Thanks. I downgraded to alpha1 since there seems to be no way to get alpha2 operational. I'm now back at 'Video' 6.x-4.2-alpha1 and 'Video Upload' 6.x-4.2-alpha1, together with 'FFmpeg Wrapper' 6.x-1.1-beta2.

However, ./admin/settings/video/transcoders is still inaccessible:

Fatal error: Declaration of video_ffmpeg_wrapper::load_completed_job() must be compatible with that of transcoder_interface::load_completed_job() in /var/www/drupal/sites/all/modules/video/transcoders/video_ffmpeg_wrapper.inc on line 12

Is it necesary to downgrade even further?

Update: I located an "RC6" with Drush and downgraded to video-6.x-4.1-rc6 which gave me access to ./admin/settings/video/transcoders back; there I switched from 'FFmpeg Wrapper' to 'FFmpeg' as video transcoder, saved the settings, disabled the 'ffmpeg_wrapper module and upgraded to video-6.x-4.2-alpha2 again.

However, ./admin/settings/video/transcoders is still inaccessible. Same error message as above. Obviously some of these settings are stored somewhere else, and not updated properly.

You will have to run a separate script to load old data or do below.

I do not understand what this is supposed to tell me. What "separate script" are you referring to? What steps are required to get a properly updated 'video' module?

Then go to video_files (FFMPEG) or video_zencoder (Zencoder) tables and let them convert again by changing status to 1

I don't understand this either. Does this mean that it is required to manually fiddle with database tables to finalize the update? I do not even want the module to make any conversions.

Also, when I'm looking at the database, I'm getting this:

mysql> select * from video_files;
Empty set (0.00 sec)

So again, what steps are required to get a properly updated 'video' module?

riversidekid’s picture

If it's any help, I'm with "justageek" where I did not have FFmpeg Wrapper selected prior to upgrade and yet the transcoders page still provides this error after upgrade.

I'm with "asb" where I reverted back to the RC6 version as I just couldn't get this version to function. It failed on the transcoders page and none of my existing video would operate, although I did not delete and re-upload all my video, that would kill the voting API votes via FiveStar and that isn't an option for an upgrade at the moment.

I will add that after the upgrade the error stated that it could not find stream at /sites/default/files, although with RC6 all my video files are in /sites/default/files/video. Apparently this is set elsewhere and I just forget where!

hypertext200’s picture

@riversidekid, I tested this, there is no such an issue found for me and then what you can do is go to variables table and search for vid_trancoder variable name and delete it. It should fix the issue.

This version of video module require a more advanced FFMPEG installed to work and you can define your own preset as well.

tora_tora’s picture

I am also having this problem after upgrading, I rolled back to rc6 and confirmed that wrapper was not selected and same problem. I cannot find a vid_transcoder variable in my variables table. I am running ffmpeg 0.6.1. I have deleted everything and trying to rebuild but this problem is working me over.

hypertext200’s picture

Status: Active » Fixed

Please see #16 comment

tora_tora’s picture

Status: Fixed » Active

I did all of that, I even removed and uninstalled all the modules, deleted all my content and removed the video cck type, starting as much from scratch as possible without rebuilding the whole site. There must be some kind of system incompatibility that upsets this code, maybe ffmpeg version numbers or something.

hypertext200’s picture

Go to your database and check for vid_transcoder variable and delete it.

tora_tora’s picture

I checked for that a while ago, the only 'vid_' variable is 'vid_preset'.

Jorrit’s picture

Status: Active » Postponed (maintainer needs more info)

Is this still a problem?

Jorrit’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

Closed because of lack of response.