In file .../plugins/video_ffmpeg_helper/video_ffmpeg_helper.module, the function _video_ffmpeg_helper_auto_thumbnail(&$node) function uses the wrong Drupal variable to get the offset second when to extract the thumbnail of a video. It uses video_image_auto_thumbnail_seek instead of video_ffmpeg_helper_auto_thumbnail_seek set in the form.

The impact of this error is that the thumbnail extractor will always take the frame at the 2 seconds offset, instead of using the value entered by the user.

  $debug = variable_get('video_image_auto_thumbnail_debug', false);
  $videofile = escapeshellarg($_SESSION['video_upload_file']->filepath);
  $thumbfile = tempnam(file_directory_temp(), 'tnail-thumb');
  // PME20071207 Error in variable name
  // $seek = variable_get('video_image_auto_thumbnail_seek', 2);
  $seek = variable_get('video_ffmpeg_helper_auto_thumbnail_seek', 2);
  $tnail = variable_get('video_ffmpeg_helper_ffmpeg_path', '/usr/bin/ffmpeg');

I can't submit a patch file as my source is heavily customized.

Also, this code should check that this value is lower than the duration of the video...

Comments

fax8’s picture

Status: Active » Fixed

This has already been fixed in commit http://drupal.org/cvs?commit=101650

Thanks for your help.

Fabio

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.