Denied access to private videos gives double page [#1924378]

hook_file_download() should return

If the user does not have permission to access the file, return -1. If the user has permission, return an array with the appropriate headers. If the file is not controlled by the current module, the return value should be NULL.

but Video calls drupal_access_denied.
This leads to a sort of double page and errors like "Warning: Cannot modify header information - headers already sent by ..." in the logging.

Patch attached to change it to return -1 in stead.

Comment	File	Size	Author
#4	denied_access_to-1924378-4.patch	604 bytes	anrkaid
	video-file_download_denied.patch	670 bytes	JvE

Comments

Comment #1

JvE commented 22 February 2013 at 07:31

Status:

Active

» Needs review

Comment #2

brycefisherfleig commented 9 June 2014 at 21:35

Issue summary:	View changes
Issue tags:		+7.x-2.11 roadmap

Comment #3

ydahi

Waterloo, Canada

commented 15 January 2015 at 05:32

Great, was running in to this issue - patch works perfectly fine.

Video 7.x-2.11

Comment #4

anrkaid commented 23 February 2015 at 17:18

Status	File	Size
new	denied_access_to-1924378-4.patch	604 bytes

Actually, user can have access to the converted version (for example, preview) and not have access to the original file.
Therefore, video_file_download() should return NULL in this case instead of '-1', because '-1' value means 'discard other modules overrides & deny access'.