after a couple hours of debugging, i realized that having the following in my local ~/.gitconfig, it was altering the output generated during reposync and causing test failures b/c renames were being shown differently. specifically, this section:

[diff]
  renameLimit = 0
  renames = copies

in particular, renames = copies causes concatenation of what should be two entries in versioncontrol_item_revisions down into one. and, boom, test failures.

we need to make our invocations yet more explicit, so that local variations in gitconfigs cannot cause variations in the output we receive.

this'll be something we work on incrementally, needless to say.

Comments

marvil07’s picture

marvil07 commented

Sounds like duplicate of #1551268: Use git plumbing commands on git_default reposync plugin

sdboyer’s picture

sdboyer commented
Status: Active » Postponed

it may or may not. i don't know that moving down into lower-level commands will change the way that particular option behaves. if those options effect behaviors of gitdiffcore, then all bets are off. but i can postpone pending that one, and we can test to see if there are variations.

marvil07’s picture

marvil07 commented
Title: Ensure local gitconfigs cannot change the form diff output takes during reposync » Use custom gitconfig on all git commands to avoid unexpected behaviour on parsing/calls
Version: 6.x-2.x-dev » 7.x-1.x-dev
Issue tags: +vc-next