When I took over the views stuff there were a few very yucky things in there that we carried forward but now need to clean up.

We should never have sql queries in field rendering. Though, to be fair it was impossible to avoid before views_view_field with these kinds of lists.

versioncontrol_handler_field_operation_items is first on the chopping block, others to follow

CommentFileSizeAuthor
#1 970200-starting-default-commits.patch31.39 KBtizzo
#2 Screen shot 2010-11-12 at 3.01.56 PM.png126.28 KBtizzo

Comments

tizzo’s picture

tizzo commented
StatusFileSize
new 970200-starting-default-commits.patch31.39 KB

Attached patch starts off this along with:

#970218: Create a shippable per repository view

and

#970206: Create a shippable per user commit view

tizzo’s picture

tizzo commented
Status: Active » Needs work
StatusFileSize
new Screen shot 2010-11-12 at 3.01.56 PM.png126.28 KB

Attached is a screen grab of an actual view!

[edit: note the @ signs normally go before the branch and we don't have that data ready for views to pull in easily]

marvil07’s picture

marvil07 commented
Component: API module » Commit Log

Just a comment: I think this should replace what commitlog try to do, I mean, IMHO this views must go inside that sub-module, not in the main one.

tizzo’s picture

tizzo commented

Removing versioncontrol/includes/views/handlers/versioncontrol_handler_field_operation_items.inc because it made sql calls directly from the field handler. http://drupal.org/cvs?commit=452276

tizzo’s picture

tizzo commented

Removing includes/views/handlers/versioncontrol_handler_field_operation_labels.inc because it made sql calls directly from the handler and should be deprecated by views_field_view http://drupal.org/cvs?commit=452278

marvil07’s picture

marvil07 commented
Issue tags: +views integration
eliza411’s picture

eliza411 commented
Issue tags: +git sprint 5

Tagging for consideration in git sprint 5

tizzo’s picture

tizzo commented

I'll wrap that up this sprint.

tizzo’s picture

tizzo commented
Status: Needs work » Fixed

http://drupal.org/cvs?commit=458834

I have reviewed the old stuff and I think we want everything that remains.

Status: Fixed » Closed (fixed)
Issue tags: -views integration, -git phase 2, -git sprint 4, -git sprint 5

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +views integration, +git phase 2, +git sprint 4, +git sprint 5

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 35a0985 on repository-families, drush-vc-sync-unlock by tizzo: 
    #970252, removing deprecated handler
  • Commit 0fef316 on repository-families, drush-vc-sync-unlock by tizzo:
    related to #970252, removing...
  • Commit f5597a3 on repository-families, drush-vc-sync-unlock by tizzo:
    #970252, cleaning up old views integration, fixing commenting / white...

  • Commit 35a0985 on repository-families by tizzo: 
    #970252, removing deprecated handler
  • Commit 0fef316 on repository-families by tizzo:
    related to #970252, removing...
  • Commit f5597a3 on repository-families by tizzo:
    #970252, cleaning up old views integration, fixing commenting / white...