I suppose there is a problem on admin/project/versioncontrol-accounts page.

The generated link is:
http://commitlog%3fusername%3dmarco%2520antonio%2520villegas%2520vega%25...

I see 3b3e83ead0aca3edf441746767c129b7561c7386 is the first bad commit(woo git bisect!), but I can not understand the real problem.

Is there a problem?

Comments

jpetso’s picture

  • I don't seem to have a commit named 3b3e83ead0aca3edf441746767c129b7561c7386.
  • I don't experience any error that leads to the above URL.
  • My recent statistics commit introduced changes and I obviously forgot to fully port the piece of code that generates the admin page.
  • The latter is now fixed.

Could you please check if the error is still present on current HEAD?

marvil07’s picture

Maybe we are talking about different repos, I see the mentioned comit on you repo.

To reproduce it:

- add a vcs repo
- add an vcs account in that repo
- go to admin/project/versioncontrol-accounts
- see/click user filter link

jpetso’s picture

Status: Active » Fixed

You're right, and I must have done something wrong with grepping the "git log" output. The bug was caused by commitlog_account_url() returning a relative URL instead of an absolute one (which causes l() to generate incorrect links), and that's now fixed too. Thanks for the report!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.