Problem/Motivation

We need versioncontrol.module to run on PHP7+ before #2327607: [meta] Plan port to D8

Although the existing test suite passes on a site running PHP 7.4, https://github.com/PHPCompatibility/PHPCompatibility is showing the following:

---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------
 445 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and
     |         | removed since PHP 5.4
---------------------------------------------------------------------------------

Proposed resolution

Make it fully compatible with modern PHP. Remove the check for 'safe_mode'.

Remaining tasks

  1. Audit / test.
  2. Fix any problems.
  3. Reviews
  4. RTBC
  5. Commit

User interface changes

None.

API changes

Hopefully none.

Data model changes

Hopefully none.

Release notes snippet

TBD.

CommentFileSizeAuthor
#2 3138034-2.patch532 bytesdww

Comments

dww created an issue. See original summary.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 3138034-2.patch532 bytes

This simply removes the check for 'safe_mode'. PHPCompatibility is happy with this applied, and the test suite for this module still passes all tests. However, I'm not sure the test suite exercises hook_cron at all, so it'd be nice to have someone more familiar confirm this is okay before it's committed.

  • marvil07 committed 981616a on 7.x-1.x authored by dww 
    Issue #3138034 by dww: Remove safe_mode check

The safe_mode option was...
marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

@dww, Thanks for the report and the patch!

Indeed, safe_mode was removed a while ago, so this check to verify if the code is allowed to modify ini settings is no longer needed, since the removal, it is always allowed AFAIK.

I have just added the change to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.