Problem/Motivation

Blocks filter in layout builder is shown fully white so the placeholder doesn't show.

Steps to reproduce

- Open any page with layout builder with dark theme.
- Choose add block in the layout builder.
- Notice that the filter bellow add a custom block doesn't show a placeholder

Before the fix:

Proposed resolution

  • Add &::placeholder with style to all input form elements in #drupal-off-canvas or #layout-builder-modal
  • Switch to use var(--input-fg-color--placeholder) Claro's CSS3 variable.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.3, varbase_layout_builder-10.1.4, varbase-9.1.7, varbase_layout_builder-10.0.57

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3480375 by oways23, alshami: Fixed Blocks Filter Not Showing Placeholder in Off-Canvas or Layout Builder Modal
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

oways23 created an issue. See original summary.

oways23’s picture

Assigned: oways23 » Unassigned
Status: Active » Needs review

Submit for review.

alshami made their first commit to this issue’s fork.

alshami’s picture

I've updated the MR, As we shouldn't exclude one by one all the fields, we may just change the placeholder color. and I'm sure that this is the better approach here.

rajab natshah’s picture

Title: Blocks filter doesn't show the placeholder in layout builder » Fix Blocks Filter Not Showing Placeholder in Off-Canvas or Layout Builder Modal
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

  • rajab natshah committed 95518dd3 on 10.0.x
    Issue #3480375 by oways23, alshami: Fix Blocks Filter Not Showing...
rajab natshah’s picture

Issue summary: View changes

Switch to use var(--input-fg-color--placeholder) Claro's CSS3 variable.

  • rajab natshah committed 28f4a004 on 10.0.x
    Issue #3480375: Switch to use var(--input-fg-color--placeholder) Claro's...

  • rajab natshah committed ca48503f on 10.1.x
    Issue #3480375: Switch to use var(--input-fg-color--placeholder) Claro's...
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.1.7

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.3

rajab natshah’s picture

Issue summary: View changes