I got the following notice message after executing views bulk operation actions on Views:
Notice: Undefined property: stdClass::$revision in userpoints_nc_revision_node_update() (line 12 of /***/sites/all/modules/contrib/userpoints_nc/userpoints_nc_revision/userpoints_nc_revision.module).
Drupal 7.8
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | userpoints_nc_revision-1294648-1.patch | 772 bytes | euginewm |
| #17 | undefined_property-1294648-1.patch | 680 bytes | euginewm |
| #9 | revision_not_empty-1294648-4.patch | 828 bytes | euginewm |
| #7 | revision_not_empty-1294648-4.patch | 932 bytes | euginewm |
| #4 | Issue_ID_202967_1.patch | 929 bytes | euginewm |
Comments
Comment #1
Refineo commentedI cannot reproduce this issue after installing userpoints_nc-7.x-1.0-rc1. Issue solved.
Comment #2
euginewm commentedI have a rule in which is adding a new node.
The action of this rule is accruing points for the user.
Each time a rule is triggered, I get this error.
Comment #3
Refineo commented@eugen-black I am also interested in finding out what is the root cause here.
Did you test the latest dev ? If so, maybe you could reopen this issue for 7.x-1.x-dev attaching more details?
What versions of Drupal, Rules , Userpoints do you use?
Can you attach the rule that causes this error message for you?
Comment #4
euginewm commentedPlease, see my patch.
I use v. 1.0
Comment #5
euginewm commentedComment #7
euginewm commentedComment #9
euginewm commentedComment #10
euginewm commentedComment #12
euginewm commentedComment #13
berdyshev commented#9: revision_not_empty-1294648-4.patch queued for re-testing.
Comment #15
Refineo commentedPlease see the test error log:
Is the userpoints_nc_revision.module file missing in the qa repository ?
Comment #16
berdirYou need to create the patch from within the userpoints_nc module, so that userpoints_nc is *not* part of the path in the patch. You probably need to adjust your --relative option as this usually doesn't show up if you have a git checkout of the actual module.
Comment #17
euginewm commentedYes, the property is "--relative" was helpful. I finally understood how to use the command git diff
I state in root dir of project and use follow command:
git diff --relative=sites/all/modules/contrib/userpoints_nc/userpoints_nc_revision > [description]-[issue-number]-[comment-number].patchComment #19
euginewm commented#17: undefined_property-1294648-1.patch queued for re-testing.
Comment #21
euginewm commentedWhy? please, tell me, what wrong in my patch format?
Comment #22
berdirNow you're one level too deep. the userpoints_nc_revision directory must be part of the path. Patches always need to apply from the root of the project, not the module.
Comment #23
berdirComment #24
euginewm commentedComment #25
euginewm commentedComment #26
itz_andr3 commentedI added some info:
this also happend on working with module node convert:
http://drupal.org/project/node_convert
when convert from 1 type to another, after save that will accured,
maybe it trigers a revision action
the good thing, user point not change.
**the more advance flow, i think, the point category should change too, equal to category points setting in the convert node target.
Comment #27
Refineo commentedPatch #24 tested successfully and corrects the issue.
Before applying the patch in #24
when I go to view Content (Emulates the Drupal content administration page.) /admin/content2
I select a Basic Page node (test) using the bulk operations checkbox and choose operation: unpublish content
I click "Confirm" button.
The node is updated however I get notice:
Notice: Undefined property: stdClass::$revision in userpoints_nc_revision_node_update() (line 12 of /***/userpoints_nc/userpoints_nc_revision/userpoints_nc_revision.module).After I apply patch from #24
Bulk operations work as expected without error notice messages.
I tested:
Tested on Drupal 7.12
Comment #28
berdirThanks for testing, commited.