Patches offered for future: points only on publication / only positive points into moderation

I don't have time to examine the details, but yes, patches are normally accepted provided they do not break backwards compatibility, and are configurable. They have to be tested and reviewed by at least 2 people before they can be included.

I created a patch for 2. for esllou.

Please review.

Please explain what this patch does. Use cases, ...etc.

this looks interesting. I have negative points for pageviews on a site. I'll test this out tomorrow. Thanks for the patch!

tested this patch this morning. Works fine. Great addition. Ta!

@esllou

Please don't rush maintainers. Give them time, they are busy people.

@jbrown

I am wondering if this can be done in an external module, rather than the userpoints API itself.

There is the 'moderate' flag, which can be set to true or false. Combine that with the points before, and you probably get what you need, without a modification to userpoints.

Try this, before we cram complexity and cruft to the module itself.

function yourmodule_userpoints($op, &$params = array()) {
  if ($op == 'points before') {
    // Is points negative?
    if ($params['points'] < 0) {
       // Turn off moderation
         $params['moderate'] = FALSE;
    }
  }
}

It could be that the code snippet I mentioned needs some tweeks.

More debugging is needed to see if the 'moderate' modification takes effect or not.

Specifically, this code in userpoints.module:userpoints_userpointsapi()

    if (!isset($params['moderate'])) {
      //if not passed then site default is used
      $params['status'] = variable_get(USERPOINTS_POINTS_MODERATION, 0);
    }
    else { 
      if ($params['moderate'] == true) {
        $params['status'] = 1;
      }
      else {   
        $params['status'] = 0;
      }
    }

There is some similar code in the transaction function too.

This is not something I have time for, so someone else needs to confirm it.

$params is currently not passed by reference, so it's not possible to do that :) Just like any other modification.

#668284: hook_userpoints pass $params by reference would change that.

Also, since this patch is actually in the rules integration category, wouldn't it be better to provide Moderate "default/yes/no" as a option when creating a rule? That's much more flexible than a generic negative points are not moderated option.

+++ userpoints.module	8 Jun 2010 16:29:49 -0000
@@ -581,7 +588,12 @@
+      if (variable_get(USERPOINTS_POINTS_MODERATION, 0)) {
+      ¶
+        if ($params['points'] > 0 || (variable_get(USERPOINTS_POINTS_MODERATION_NEGATIVE_BYPASS, 0) == 0)) {

There are some trailing whitespaces that should be removed when the patch is re-rolled, but depending on the above idea, it might look totally different anyway :)

Powered by Dreditor.

I still think that a separate module could do this, without the need to over-complicate the API with special cases.

Let us resist this temptation for increased complexity.

No, it can't, unless you commit the linked issue :)

Currently, modules can not change anything in $params, ever :)

Also, I agree with not adding complexity, that's why I suggested to make this a per-action/rule option for rules integration (only). In my opinion, rules integration should be as feature-complete as possible, allowing control over any setting/field/option that userpoints_userpointsapi() supports.

Closing this as outdated, 6.x version is no longer maintained.