This allows us to drop various custom things, will need a bit of refactoring, though.

CommentFileSizeAuthor
#7 revert_default_uri_cleanup.patch54.69 KBberdir
#5 now_with_views_controller.patch55.5 KBberdir
#4 fixed_rules_tests.patch46.29 KBberdir
#1 use_entity_module.patch31.12 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new use_entity_module.patch31.12 KB

A first patch.

Not perfect yet, but brings us closer back to how other contrib modules work and also Drupal 8 will.

Additional things to be done here will include relying on the metadata controller for the properties, views controller for the views integration, at least for transactions. Also ui controller for the bundle administration.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, use_entity_module.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new fixed_rules_tests.patch46.29 KB

Ok, moved the properties definition to the controller and fixed up the rules tests and dropped the after hook that one is gone for good :) (Aka, has been replaced by the default update/insert hooks).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new now_with_views_controller.patch55.5 KB

And now a patch which also adds the views controller. Not perfect yet but a basic view can be built including support for VBO.

Category is for example just the id, but that's not really relevant as that will be replaced by an actual bundle anyway.

Another ~200 lines of code saved :)

Status: Needs review » Needs work

The last submitted patch, now_with_views_controller.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new revert_default_uri_cleanup.patch54.69 KB

Oh well, looks like the defaultUri() cleanup conflicts with the current category filtering, so this will have to wait until that has been replaced by view or otherwise removed :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited this. This isn't really finished and there will be some loose ends like the views integration but this commited allows to continue in different issues and get them back on track like the field one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.