Any plans for D7 port?

CommentFileSizeAuthor
#1 d7-port-user-limit-1780302-1.patch11.45 KBgeerlingguy

Comments

geerlingguy’s picture

Assigned: Unassigned » geerlingguy
Status: Active » Needs review
StatusFileSize
new11.45 KB

I ported everything, and cleaned up a bit. Some additional changes besides a straight port:

  • Removed hook_perm() (now hook_permission()), as the permission was never used anywhere.
  • Rearranged source order in main .module file, so it follows normal convention of core hooks, then form alters, then helper functions.
  • Made the 'current status' message (e.g. current / limit) on the user registration form optional. (Added a new variable for this).
  • Cleaned up documentation here and there to conform to coding standards.
  • Removed the submit handler for the user settings admin form, since system_settings_form() takes care of saving all the variables.
  • Updated and rearranged the .info file.
  • Consolidated user_limit_reached() and user_limit_surpassed() into the former, since the latter is not necessary.
  • Disable the user registration form when limit is reached, instead of deleting the created account after the fact (for better UX—it's disappointing to have filled out the registration form, only to realize later that your work was for naught).
  • Updated user_limit_count_users() to use an extensible DBTNG query (which, coincidentally, fixes #1451038: Make the module PSQL friendly for D7).

I'd be happy and willing to take over as maintainer of the D7 branch of this module, if you've moved on to other projects. I'm using it for a side project that I'll be working on for the next year or two, so I'm definitely invested in its well-being.

ergonlogic’s picture

@geerlingguy, thanks! I've added you as a maintainer. Go crazy!

I'm not making use of this at the moment, hence my pretty much ignoring it for awhile. I'll probably return to it in 6 months or so.

kaizerking’s picture

Very nice to see this ported to D7,

geerlingguy’s picture

Status: Needs review » Fixed

Fixed: http://drupal.org/node/1805414

7.x-1.0-beta1 should be out now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.