Hi, would be nice to add the option for adding the attribute "target" to the link.
I'll try to make a patch.

CommentFileSizeAuthor
#11 field_url-add_target_attr-1914126-11.patch1.43 KBdbachko
#8 1914126-add-target-blank-on-display-form.patch1.5 KBraphael apard
#3 url_field-target-added-issue1914126.patch7.14 KBesolitos
#1 field_url-issue-1914126.patch6.79 KBesolitos

Comments

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
StatusFileSize
new field_url-issue-1914126.patch6.79 KB

There it is the patch.
(It's my first time, so please be gentle :D )

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Active » Needs review
esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
StatusFileSize
new url_field-target-added-issue1914126.patch7.14 KB

Sorry, here it is a better patch.
Previous patch did brakes the "Preview" option, this one has still some issues with it, but it doesn't brake anything (as far as i know).

Status: Needs review » Needs work

The last submitted patch, url_field-target-added-issue1914126.patch, failed testing.

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Needs work » Needs review

#3: url_field-target-added-issue1914126.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, url_field-target-added-issue1914126.patch, failed testing.

ilceia’s picture

ilceia commented

I loved this module, but I need a target attribute on it real bad....Is there a very very easy way to do this? I know almost nothing

raphael apard’s picture

raphael apard commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 1914126-add-target-blank-on-display-form.patch1.5 KB

Just add : Add target="_blank" to all links on field formatter settings form.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs review » Reviewed & tested by the community

Reviewed, works for me, thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Component: Code » User interface
Assigned: esolitos » Unassigned
dbachko’s picture

dbachko commented
StatusFileSize
new field_url-add_target_attr-1914126-11.patch1.43 KB

Add optional target attribute to all links with options('_self', '_blank', '_parent', '_top') to select from.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs review

Now we need the maintainer to weight in on which approach would be better. Also, a new patch means that the status goes back to "needs review".

kolafson’s picture

kolafson commented

#11 works for me

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

#2366021: Open link in a new tab or window implemented this feature in virtually the same exact code, but restricted only to "_blank".

jcnventura’s picture

jcnventura
Primary language English
commented
Related issues: +#2366021: Open link in a new tab or window