Follow-up for #1893812: When editing a code with related content, start out displaying the related content:

DanChadwick: This does raise the question about why the jQuery removes clears the widget upon preview. Why is this desirable? I think we should also eliminate passing the preview setting to the jQuery, and the jQuery code that uses this flag to initially clear the contents. Perhaps there is a use case I don't understand. I'll leave this for a separate issue.

With the commit for the issue above I commented the mentioned uniqueness.clear() statement out. This seems to fix node previews. As Dan suggests we should cleanup the code around it...

CommentFileSizeAuthor
#1 uniqueness-preview_cleanup-1897880-1.patch3.51 KBdanchadwick

Comments

danchadwick’s picture

danchadwick commented
Status: Active » Needs review
StatusFileSize
new uniqueness-preview_cleanup-1897880-1.patch3.51 KB

Here's a patch against the current 7.x-1.x. All it does is remove the unused vestiges of special preview logic and clean up a couple of comments related to preview.

bforchhammer’s picture

bforchhammer commented
Status: Needs review » Fixed

Cleaned up a few more comments and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.