I went in and cleaned up the Drupal 7 version of this module so that it is compliant with Drupal 7 code.

Changes include:

- Replaced 'error' with WATCHDOG_ERROR in all implementations of watchdog().

- Placed drupal_http_request() options into the $options array.

- Set #default value on all form elements in unfuddle_api_admin_settings() to variable_get([Form Item]) so that the values do not get cleared from the form after they have been saved.

Please see the attached patch for a full list of changes. Let me know if any further changes are required after review.

CommentFileSizeAuthor
#1 1108246-cleaning-up-D7-version-of-unfuddle-api-D7.patch11.77 KBstephenh

Comments

stephenh’s picture

stephenh commented
StatusFileSize
new 1108246-cleaning-up-D7-version-of-unfuddle-api-D7.patch11.77 KB

Patch Attached

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Minor whitespace issue, but looks good to go

+++ b/unfuddle_api.classes.inc
@@ -346,8 +346,13 @@ class Unfuddle {
diff --git a/unfuddle_api.info b/unfuddle_api.info

diff --git a/unfuddle_api.info b/unfuddle_api.info
index 06fcb6f..313504c 100644

index 06fcb6f..313504c 100644
--- a/unfuddle_api.info

--- a/unfuddle_api.info
+++ b/unfuddle_api.info

+++ b/unfuddle_api.info
+++ b/unfuddle_api.info
@@ -1,6 +1,7 @@

@@ -1,6 +1,7 @@
 name = "Unfuddle API"
 description = "Provides API for connecting communicating with Unfuddle."
-core = 7.x
+core = 7.x ¶

Trailing whitespace

Powered by Dreditor.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.