Problem/Motivation

Slider item render issue when no value added in slider item in theme settings.

Steps to reproduce

1 Install the theme and set as default.
2 Go to the theme settings.
3 Update select number of slider display count into 5.
4 Go to the home page
5 Go to the home page
6 Go to 3, 4 and 5 slide in slider component.
you will find the broken slide issue.

Proposed resolution

Slide should not visible in FE when value not added.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 no of slides.png23.13 KBtanuja bohra
#5 after_patch.png897.31 KBtanuja bohra
#5 before_patch.png11.3 KBtanuja bohra

Issue fork ultra_zymphonies_theme-3419716

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gautam_105@ created an issue. See original summary.

adarshv made their first commit to this issue’s fork.

adarshv opened merge request !5

adarshv’s picture

adarshv commented
Status: Active » Needs review

@Ultra Zymphonies Theme Theme i have fixed this issue and created MR, Please check and review.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png11.3 KB
new after_patch.png897.31 KB
new no of slides.png23.13 KB

Verified MR5 on 9.5.x, the broken slides issue is fixed and now without data slides are not showing. Added screenshots for reference, RTBC++