Problem/Motivation

Some hosting providers do not work well with symlinks, so loading the pattern library as a composer dependency necessarily means it is not going to be located within your themes/*/theme/templates/ folder, yet the code forces this to be the case. Extending the FractalDeriver is not possible as methods are private and the addition of "/templates" to the directory is hard-coded.

Proposed resolution

Set the directory using a protected method to allow overriding.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 3272689-allow-non-theme-paths-compatible-with-3188371.patch1.19 KBscott_euser

Issue fork ui_patterns_fractal-3272689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !1

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs review

No change, just allowing override/extending of this module for non-theme locations of fractal pattern library.

scott_euser’s picture

scott_euser commented
StatusFileSize
new 3272689-allow-non-theme-paths-compatible-with-3188371.patch1.19 KB

Here's a version compatible with #3188371 (Drupal\Core\File\Exception\NotRegularDirectoryException) which changes the line next to this in the Fractal Deriver.