Problem/Motivation

annotated_name is a

It was looking like a good idea when we were building UI Patterns 2, but:

  • recurrent feedback from users show it is kind of confusing for them
  • it is not that common to have two or more components with the same names, and it doesn't play well with replace and filter mechanisms, so a component which is not sharing a label can be annotated
  • it is part of the ComponnetPluginManager override (now in ComponentDefinitionAnnotator) and we want to get rid of them as much as possible to get closer to Drupal Core

Proposed resolution

Remove the feature.

Tell Display Builder about that: #3571384: Do not show component theme name suffix if there is no other visible occurrence

Issue fork ui_patterns-3630375

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !594

pdureau’s picture

pdureau commented
Assigned: pdureau » just_like_good_vibes
Status: Active » Needs review

This is a non breaking change, because no API rely on a label.

just_like_good_vibes made their first commit to this issue’s fork.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » pdureau
Status: Needs review » Needs work

you removed the "don't use" suffix, was it intentional ?

pdureau’s picture

pdureau commented
Assigned: pdureau » just_like_good_vibes
Status: Needs work » Needs review

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.