Problem/Motivation

Upgrading to ui_patterns 1.16 took down a portion of our site and returned the following error:

Fatal error: Declaration of Drupal\ui_patterns_field_group\Plugin\field_group\FieldGroupFormatter\PatternFormatter::settingsForm(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\field_group\FieldGroupFormatterBase::settingsForm() in /modules/contrib/ui_patterns/modules/ui_patterns_field_group/src/Plugin/field_group/FieldGroupFormatter/PatternFormatter.php on line 195

It looks like the same error was happening when using ui_patterns 1.15 with field_group 4.1-alpha, so a signature change for that function was committed in this issue: https://www.drupal.org/project/ui_patterns/issues/3612514

The problem is that for many sites, composer is not configured to upgrade modules to alpha versions, so ui_patterns is being upgraded to 1.16 before field_group is updated to 4.1, causing fatal errors in those sites.

Steps to reproduce

Upgrade to ui_patterns 1.16 while using field_group 4.0 and have the display of a field group set to use a pattern.

Proposed resolution

Make the latest version of ui_patterns dependent on field_group 4.1?

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mikemccaffrey created an issue. See original summary.

shank115 made their first commit to this issue’s fork.

shank115’s picture

Status: Active » Needs review