Problem/Motivation

A couple of service injections need to be updated to typehint on the core class, not the one UI Patterns implements that extends the core class. Without this, its not possible for other downstream projects (such as mine), to further decorate core's class, because when UI Suite is used, it will crash because my class extends cores, not myclass -> uisuite -> core.

Steps to reproduce

  • Create a new class that decorates SDC service plugin.manager.sdc.
  • Extend core class.
  • Visit relevant UI Patterns/suite routes.
  • WSOD

Proposed resolution

Change the imported class to the root-most core class.

Usually in Drupalland we'd use an interface, and thats probably lead to this oversight.

Remaining tasks

Nil.

User interface changes

Nil.

API changes

Nil.

Data model changes

Nil.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dpi created an issue. See original summary.

dpi’s picture

Assigned: dpi » Unassigned
Status: Active » Needs review

Note, there are other service imports which are already using the core class typehint. These are just the stragglers/oversights.

just_like_good_vibes’s picture

Hello, thank you for reporting. This is funny because we talked about that with @pdureau last friday just before the weekend, and on Monday the issue is here :)

dpi’s picture

Sure thing, This'll help accelerate experimentation integrating Pinto with Display Builder, as we'll be synthesizing SDC's [just like UI Suite does?].

just_like_good_vibes’s picture

Assigned: Unassigned » just_like_good_vibes
Status: Needs review » Needs work

i am continuing your work and i will make a proposition