Problem/Motivation

The next major version of UI Patterns is not planned yet, so we are not dropping UI Patterns 1.x compatibility yet, but we can start the work by removing some parts.

Proposed resolution

It is important to keep as long as possible the 2 migration processes:

  • drush ui-patterns:migrate-patterns for the UI components (code)
  • drush ui-patterns:migrate-configuration for the configuration

We can drop sooner the more "niche" compatibility layer:

  • pattern and pattern_preview render elements
  • pattern() and pattern_preview() Twig functions
  • \Drupal\ui_patterns_legacy\Dummy\LinksSettingType

Issue fork ui_patterns-3590440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !496

pdureau’s picture

pdureau commented
Status: Active » Needs review

Too soon to merge now, because it is an #ui_patterns-next ticket, but moving to RTBC would be nice.

2 phpunit fails don't seem related to the current work and are also met in #3589204: Drupal 12 and phpunit:

1) Drupal\Tests\ui_patterns_layouts\Functional\LayoutBuilderRenderTest::testRenderSlotsReplaced
Behat\Mink\Exception\ElementTextException: The text "field_text_1 value" was not found in the text of the element matching css ".ui-patterns-test-form-replaced-slot".
2) Drupal\Tests\ui_patterns_layouts\Functional\LayoutBuilderRenderTest::testRenderSlots
Behat\Mink\Exception\ElementTextException: The text "field_text_1 value" was not found in the text of the element matching css ".ui-patterns-slots-slot".
pdureau’s picture

pdureau commented
Assigned: Unassigned » grimreaper

Can you RTBC if you are OK?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau
Status: Needs review » Reviewed & tested by the community

RTBC but...

This should have been using proper deprecation mechanism to be detected by code analysis tools and automated tests.
Also should have mentioned in which version the compatibility layer will be dropped.

Searching if documentation needs to be updated, I realized that in docs/faq.md, the documentation was not updated to indicate that config migration is ready.

### Do you provide configuration migration (entity displays, views...)?

pdureau’s picture

pdureau commented
Status: Reviewed & tested by the community » Needs work

Thanks for the feedbacks, so this task still need works.

The documentation update will be done in a dedicated issue.

pdureau changed the visibility of the branch 3590440-drop-parts-of to hidden.

pdureau’s picture

pdureau commented
Assigned: pdureau » just_like_good_vibes
Status: Needs work » Reviewed & tested by the community

Checked with Florent (@grimreaper), ok for RTBC