Problem/Motivation

Canvas 1.0.0-beta1 has been released and it is not cohabiting well with UI Patterns 2:

  • the main reason is because of none of the two has a proper ComponentPluginManager decorator. We decoarte the service but we do inheritance over composition, so they don't chain properly. We will be deal with this problem in dedicated issues.
  • the other reasons are some quircks in both modules. Big ones in Canvas, small ones in UI Patterns.

Proposed resolution

Fix the quirks to make cohabitation with Canvas smoother

Issue fork ui_patterns-3550146

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !445

pdureau’s picture

pdureau commented
Status: Active » Needs work

Work in progress

pdureau’s picture

pdureau commented
Assigned: pdureau » christian.wiedemann
Status: Needs work » Needs review
christian.wiedemann’s picture

christian.wiedemann commented

I checked that localy. Looks good from my side. But actually every component should have a UI Patterns key. Also canvas components. Maybe it is problem of the decorator?

pdureau’s picture

pdureau commented
Status: Needs review » Reviewed & tested by the community

Indeed, if decorators are working well, every SDC component will have a ui_patterns key because both Canvas and UI Patterns decorators will be run.

But today the decorators are not chaining, so let's be careful and nor presume ui_patterns key is always present.

christian.wiedemann’s picture

christian.wiedemann commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.