Problem/Motivation

Views Style plugin seem to have some legacy code remaining and its settings are saved in a double depth array that has no reason to be.

  • The buildOptionsForm method contains an empty HTML id for "ajax"
  • The defineOptions method has a really peculiar syntax
  • Patterns settings are saved under options > ui_patterns > ui_patterns without reason.

Proposed resolution

Clean up the code and the settings structure
Write an upgrade path

Issue fork ui_patterns-3540946

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

duaelfr created an issue. See original summary.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Issue summary: View changes

duaelfr opened merge request !426

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Needs review
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

Yay! All green!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Thanks!

I will try to test that this afternoon.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » duaelfr

Update tested from a fresh Sobki Bootstrap install.

Update Ok, Views still working after update

Just a minor best practice on hook_update_n number, otherwise RTBC.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned

Ready for the next review :)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

Thanks :)

pdureau’s picture

pdureau commented
Title: [2.1.0] Clean up Views Style plugin » Clean up Views Style plugin
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Reviewed & tested by the community » Postponed

Hello guys,
this introduces a breaking change in the config structure.
you will answer me that there is an update hook and i would agree.
But also, this does not introduce anything new or urgent, just a nice to have.
let's wait the next weekly to vote if we merge that now or keep it for later :)

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Postponed » Reviewed & tested by the community
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Assigning to me for a check after rebase now that UIP1 upgrade had been merged.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » just_like_good_vibes

Ready to merge :)

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Reviewed & tested by the community » Postponed

hello guys, sorry a bit risky right now, we postpone for later if you don't mind