Problem/Motivation
#3390712: Add component variants to SDC was merged in Core and will be shipped with 11.2
Proposed resolution
Is it compatible with our own variant system ?
API changes
We are still supporting Drupal 10.3+ so this issue will not be the opportunity of removing our own impelmnattion and any change we do must be compatible with Drupal 10.3+
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | drupal - UI patterns - 3522873.png | 13.84 KB | sharique |
Issue fork ui_patterns-3522873
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
sharique commentedI did the quick testing for this as follows.
There is one error I got when enabling module, I'll create a separate ticket for it
Comment #3
smovs commentedThank you @sharique, for testing and your feedback.
I tested it a bit as well, and here are my results:
Tested env:
Crupal Core: 11.2-dev
PHP: 8.3.19
UI Patterns: 2.0.3
During the installation of the ui_patterns 2.0.3, I got an error about the compatibility with the Drupal Core implementation (
ComponentPluginManager::processDefinitionCategor)Also, I installed and tested these themes as origins for the components :
ui_suite_bootstrap (5.1.0-beta1)
ui_suite_material (2.0.0-beta1)
ui_suite_daisyui (5.0.0-alpha2)
Each of them was installed and worked without errors.
I can confirm variants like primary, danger, warning, etc., from the abovementioned themes work without issues in Drupal 11.2.
Comment #4
pdureau commentedGreat, thanks both.
ComponentPluginManager::processDefinitionCategoryis managed in an other issue: #3506207: [2.0.4] PHPSTAN next minor warningsComment #5
grimreaperComment #6
pdureau commentedComment #7
pdureau commentedGrimreaper has found something !
Comment #9
grimreaperWe encountered:
In vendor/justinrainbow/json-schema/src/JsonSchema/SchemaStorage.php:
$jsonPointer->getPropertyPaths() is empty and $refSchema = $this->getSchema($fileName); get empty enum.
Removing special $ref for variant fixes the problem. Somehow no problem with other special $ref of UI Patterns 2.
Comment #11
pdureau commentedthat was a weird one, but i have merged