When using props keys: 'tag', 'type', 'attributes', 'value', 'attached', they are interpreted as $html_tag_allowed_render_keys in the function convertRenderArray function of StoriesSyntaxCpnverter.
To pevent this, we should exclude the element props, from being converted.
Issue fork ui_patterns-3515500
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
kensae commentedComment #4
pdureau commentedThanks you so much Kensae, your solution is very pragmatic, targeting exactly where the issue here in SDC prop conversion.
However, we are currently facing a similar issue in UI Example module: #3505217: Support render arrays using render properties as render children and I would address to address both:
So, I let this in review state for now.
Comment #5
grimreaperComment #6
grimreaperComment #7
grimreaperComment #8
grimreaperComment #9
pdureau commentedDo we need tests mixing
#-prefixed properties and not already#-prefix properties?Data:
Expected:
Data:
Expected:
Data:
Expected:
And also, some tests about
#theme: layoutwhich is the reason why we started this work.Comment #10
pdureau commentedComment #11
grimreaperMR updated.
Comment #13
pdureau commentedComment #14
pdureau commented