Problem/Motivation

As a follow-up of #3463161: [2.0.0-beta5] Do we keep BlockSource plugin?

Today we have a blacklist of non working blocks: https://git.drupalcode.org/project/ui_patterns/-/blob/2.0.x/ui_patterns....

  unset($definitions['system_messages_block']);
  unset($definitions['help_block']);
  unset($definitions['local_tasks_block']);
  unset($definitions['local_actions_block']);
  unset($definitions['system_main_block']);
  unset($definitions['page_title_block']);

Taking inspiration from similar mechanism in Layout Builder.

But some unknown blocks (custom code, or blocks from contrib modules) will not be working too.

Proposed resolution

Proposals:

  • a whitelist of blocks known for working well instead of a blacklist
  • OR we can add only blocks already instantiated in block layout page, for example in a hidden region
  • Or we open a modal window where instanciate the block and store it somehow in a temp store and than we take it store it in our config.

Which one do we do?

API changes

No, forbidden in RC.

Data model changes

No, forbidden in RC.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Title: [2.0.0-rc1] Do we keep BlockSource plugin? » [2.0.0-rc1] Fix BlockSource
pdureau’s picture

Personally, I prefer the whitelist if a black list is not possible anymore.

just_like_good_vibes made their first commit to this issue’s fork.

just_like_good_vibes’s picture

Assigned: just_like_good_vibes » pdureau
Status: Active » Needs review

finally...

pdureau’s picture

Assigned: pdureau » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.