Problem/Motivation

Check the performance of serialization costs cache key generation in UI Patterns. Lets check the performance

Issue fork ui_patterns-3476469

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

christian.wiedemann created an issue. See original summary.

pdureau’s picture

pdureau commented
Title: [] Measure serialization costs cache key generation of getDefinitions » [2.0.0-rc1] Measure serialization costs cache key generation of getDefinitions

christian.wiedemann opened merge request !292

christian.wiedemann’s picture

christian.wiedemann commented
Status: Active » Postponed (maintainer needs more info)
pdureau’s picture

pdureau commented
pdureau’s picture

pdureau commented
Title: [2.0.0-rc1] Measure serialization costs cache key generation of getDefinitions » [2.0.0-rc1] Add performance tests
pdureau’s picture

pdureau commented
Status: Postponed (maintainer needs more info) » Needs work

Visualization with Grafana is too complicated to add in the gitlab CI pipeline. No asset in the tests, so it is useless for gitlab CI pipeline but still useful for local dev environment.

So, let's do that:

  1. rebase from 2.0.x
  2. fix PHPCS issues
  3. add a very explicit comment (README?) to tell people this is only useful when grafana is installed and how to set up the test
  4. merge
pdureau’s picture

pdureau commented
Assigned: christian.wiedemann » pdureau
Status: Needs work » Needs review

Let's wait pipeline to finsih

pdureau’s picture

pdureau commented
Status: Needs review » Reviewed & tested by the community

Auto merge

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

christian.wiedemann’s picture

christian.wiedemann commented